Add Buffer "constructor-kwargs" header #4164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of `Buffer`'s serializers' work includes handling subclasses (like cuML's `Array`). However it doesn't handle any keyword arguments those subclass constructors may need. This changes that by adding an optional (by default trivial) "constructor-kwargs" header. Subclasses can then call their parents' serializer and pack this header with relevant content afterwards. This way during deserialization this content can be passed into the subclass' constructor.
11 tasks
Codecov Report
@@ Coverage Diff @@
## branch-0.13 #4164 +/- ##
============================================
Coverage 86.67% 86.67%
============================================
Files 50 50
Lines 9818 9819 +1
============================================
+ Hits 8510 8511 +1
Misses 1308 1308 Continue to review full report at Codecov.
|
|
rerun tests |
kkraus14
approved these changes
Feb 18, 2020
kkraus14
added
5 - Ready to Merge
rapids-bot bot
pushed a commit
that referenced
this pull request
Nov 2, 2022
This PR replaces `DeviceBufferLike` with `Buffer` and clear the way for a spillable sub-class of `Buffer`. #### Context The introduction of the [`DeviceBufferLike`](#11447) protocol was motivated by [the spilling work](#11553), which we initially thought would have to be implemented in Cython. However, it can be done in pure Python, which makes `DeviceBufferLike` an unneeded complexity. #### Review notes - In order to introduce a spillable-buffer in the future, we still use a factory function, `as_buffer()`, to create Buffers. - `buffer.py` is moved into the submodule `core.buffer` to ease organization when adding the spillable-buffer and spilling manager. #### Breaking This PR breaks external use of `Buffer` e.g. `Buffer.__init__` raise an exception now and the `"constructor-kwargs"` header from #4164 has been removed. Submitted a PR to fix this in cuml: rapidsai/cuml#4965 ## Authors: - Mads R. B. Kristensen (https://github.com/madsbk) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) - Ashwin Srinath (https://github.com/shwina) URL: #12009
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of
Buffer's serializers' work includes handling subclasses (like cuML'sArray). However it doesn't handle any keyword arguments those subclass constructors may need. This changes that by adding an optional (by default trivial) "constructor-kwargs" header. Subclasses can then call their parents' serializer and pack this header with relevant content afterwards. This way during deserialization this content can be passed into the subclass' constructor.cc @dantegd