-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add static type checking via Mypy #6381
Conversation
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
Codecov Report
@@ Coverage Diff @@
## branch-0.18 #6381 +/- ##
===============================================
+ Coverage 82.09% 82.17% +0.08%
===============================================
Files 97 99 +2
Lines 16474 16805 +331
===============================================
+ Hits 13524 13810 +286
- Misses 2950 2995 +45
Continue to review full report at Codecov.
|
rerun tests |
@gpucibot merge |
rerun tests |
Rerun tests |
Looks like a flaky test related to the groupby sorting change:
|
Looking into it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review. This is great. :)
@gpucibot merge |
@@ -71,7 +71,7 @@ def test_melt(nulls, num_id_vars, num_value_vars, num_rows, dtype): | |||
@pytest.mark.parametrize( | |||
"dtype", | |||
list(NUMERIC_TYPES + DATETIME_TYPES) | |||
+ [pytest.param("str", marks=pytest.mark.xfail())], | |||
+ [pytest.param("str", marks=pytest.mark.xfail())], # type: ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason for tests to provide type annotations? (annotations for test utilities, I can see being helpful, but not limited-scope test code).
Adds static type checking to cuDF Python via MyPy.
mypy
style check is enabled in CImypy
is run as part of the pre-commit hook