remove flake8, clang tools from wholegraph CMake #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
improvement
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
jameslamb
commented
Jan 6, 2025
| @@ -127,9 +127,6 @@ message(VERBOSE "PYLIBWHOLEGRAPH: Enable detection of conda environment for depe | |||
| ############################################################################## | |||
| # - Compiler options --------------------------------------------------------- | |||
|
|
|||
| # this is needed for clang-tidy runs | |||
| set(CMAKE_EXPORT_COMPILE_COMMANDS ON) | |||
|
|
|||
There was a problem hiding this comment.
This is just a cleanup, not a behavior change... this option is already set to ON earlier in the same file.
jameslamb
changed the title
linhu-nv
approved these changes
Jan 7, 2025
|
Thanks @linhu-nv ! I might have one or two more coming like this, appreciate your help and patience 😊 |
|
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Jan 16, 2025
Proposes some simplifications for `wholegraph` CMake: * removes code adding timing information via `RULE_LAUNCH_COMPILE` and `RULE_LAUNCH_LINK` - *these are internal to `ctest`, per https://cmake.org/cmake/help/latest/prop_dir/RULE_LAUNCH_LINK.html* * removes `find_package(Python)` and related code in `pylibwholegraph` - *this is already handled by `rapids_cython_init()`: https://github.com/rapidsai/cugraph-gnn/blob/87455cfedcc6721f24c783ba555af14a9a180624/python/pylibwholegraph/CMakeLists.txt#L119-L120* ## Notes for Reviewers ### Benefits of doing this? Similar to #102 and #103, I'm putting up PRs like this because I'm planning to attempt to add libwholegraph wheels, and want to simplify the wholegraph / pylibwholegraph CMake as much as possible before doing that, to reduce the implementation and reviewing effort. Authors: - James Lamb (https://github.com/jameslamb) Approvers: - https://github.com/linhu-nv URL: #109
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wholgraph's CMake has some configuration to runflake8,clang-tidy, andclang-foramtvia CMake.This proposes removing it.
Notes for Reviewers
Risks to doing this?
I don't think any.
flake8andclang-formatconfigs are unnecessary, as those are already run viapre-commithere:cugraph-gnn/.pre-commit-config.yaml
Line 22 in 71675d8
cugraph-gnn/.pre-commit-config.yaml
Line 37 in 71675d8
The
clang-tidysupport must not actually be used today... it refers to a script that doesn't exist in this repo:cugraph-gnn/cpp/cmake/CodeChecker.cmake
Lines 42 to 43 in 71675d8
This code had been in the
wholegraphrepo for a while... it was added in June 2023 (rapidsai/wholegraph#24) and then never modified again.Benefits of doing this?
Similar to #102, I'm putting up PRs like this because I'm planning to attempt to add
libwholegraphwheels, and want to simplify thewholegraph/pylibwholegraphCMake as much as possible before doing that, to reduce the implementation and reviewing effort.