Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] MNMG Louvain code cleanup #1220

Closed
ChuckHastings opened this issue Oct 14, 2020 · 1 comment · Fixed by #1423
Closed

[ENH] MNMG Louvain code cleanup #1220

ChuckHastings opened this issue Oct 14, 2020 · 1 comment · Fixed by #1423
Assignees
@ChuckHastings
Milestone
0.19

Comments

@ChuckHastings
Copy link
Collaborator

PR #1172 created an MNMG Louvain implementation.

In order to achieve this implementation, some temporary APIs were exposed in the graph_view_t object. These should be cleaned up.
@ChuckHastings ChuckHastings added the ? - Needs Triage Need team to review and classify label Oct 14, 2020
@BradReesWork BradReesWork added Refactor and removed ? - Needs Triage Need team to review and classify labels Nov 4, 2020
@BradReesWork BradReesWork added this to the 0.17 milestone Nov 4, 2020
@BradReesWork BradReesWork modified the milestones: 0.17, 0.18 Nov 23, 2020
@BradReesWork BradReesWork modified the milestones: 0.18, 0.19 Feb 1, 2021
@ChuckHastings ChuckHastings mentioned this issue Feb 24, 2021
Merged
@github-actions
Copy link

github-actions bot commented Mar 3, 2021

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

rapids-bot bot pushed a commit that referenced this issue Mar 30, 2021
@ChuckHastings
Update Louvain to use new graph primitives and pattern accelerators (#…
e60d9f7 
…1423)

Implement the `update_by_delta_modularity` method using the new graph primitives and pattern accelerators.

This eliminates all of the custom MNMG implementation originally created for MNMG Louvain a few releases ago and replaces it with the new pattern accelerator and graph primitives that have been added in the last couple of releases.

This depends on the following PRs and should not be merged until after them:
* #1394 
* #1399 

closes #1220

Authors:
  - Chuck Hastings (@ChuckHastings)

Approvers:
  - Andrei Schaffer (@aschaffer)
  - Seunghwa Kang (@seunghwak)
  - Rick Ratzel (@rlratzel)
  - Alex Fender (@afender)

URL: #1423
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChuckHastings ChuckHastings

Labels
None yet
Projects
None yet
Milestone
0.19
Development

Successfully merging a pull request may close this issue.

Update Louvain to use new graph primitives and pattern accelerators ChuckHastings/cugraph
2 participants
@BradReesWork @ChuckHastings