Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Add gtest to conda package #1266

Closed
ChuckHastings opened this issue Nov 11, 2020 · 0 comments · Fixed by #1367
Closed

[ENH] Add gtest to conda package #1266

ChuckHastings opened this issue Nov 11, 2020 · 0 comments · Fixed by #1367
Assignees
@rlratzel
Milestone
0.18

Comments

@ChuckHastings
Copy link
Collaborator

Apparently cudf and cuml have shifted to installing the test conda package rather than bringing gtest in as a cmake dependency.

Adding gtest as a conda package to the cugraph_dev environment would make it easier to test raft code and cugraph code concurrently.
@ChuckHastings ChuckHastings added the ? - Needs Triage Need team to review and classify label Nov 11, 2020
@afender afender added the tests label Nov 30, 2020
@afender afender added this to the 0.18 milestone Nov 30, 2020
@BradReesWork BradReesWork removed the ? - Needs Triage Need team to review and classify label Dec 17, 2020
@rlratzel rlratzel mentioned this issue Feb 1, 2021
Merged
@rapids-bot rapids-bot bot closed this as completed in #1367 Feb 4, 2021
rapids-bot bot pushed a commit that referenced this issue Feb 4, 2021
@rlratzel
Update CMakeLists.txt files for consistency with RAPIDS and to suppor…
7266cdb 
…t cugraph as an external project and other tech debt removal (#1367)

This PR makes cuGraph's cmake files more consistent with other RAPIDS libs by matching the minimum required cmake version, adding `project()` statements to cugraph's thirdparty modules, and using `CMAKE_CURRENT_SOURCE_DIR` appropriately so paths are relative to the CMakeLists.txt file rather than the top-level cmake dir of the project (since that may not be the cugraph cpp dir in the case of cugraph being used as an external project by another application).

This also adds a `CUDA_ARCHITECTURES=OFF` setting to suppress the warning printed for each test target. This setting may be replaced/changed once the findcudatoolkit feature is used in a future cmake version.

This also removes the Arrow and GTest cmake files since Arrow is not a direct dependency and those files were not being used, and GTest is now a build requirement in the conda dev environment and does not need to be built from source (the conda dev env files have been updated accordingly).

This PR also addresses much of #1075 , but not completely since gunrock is still using `ExternalProject` due to (I think) updates that need to be made to their cmake files to support this.

This was tested by observing a successful clean build, however it was **not** tested by creating a separate cmake application to simulate cugraph being used as a 3rd party package.

Note: the changes in this PR were modeled after rapidsai/rmm#541

closes #1137 
closes #1266

Authors:
  - Rick Ratzel (@rlratzel)

Approvers:
  - Chuck Hastings (@ChuckHastings)
  - AJ Schmidt (@ajschmidt8)
  - Brad Rees (@BradReesWork)

URL: #1367
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rlratzel rlratzel

Labels
None yet
Projects
None yet
Milestone
0.18
4 participants
@rlratzel @BradReesWork @ChuckHastings @afender