Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] update and refactor all cuGraph to use rmm's new cuda_stream_view #1422

Closed
seunghwak opened this issue Feb 22, 2021 · 1 comment
Closed

[ENH] update and refactor all cuGraph to use rmm's new cuda_stream_view #1422

seunghwak opened this issue Feb 22, 2021 · 1 comment
Labels
improvement Improvement / enhancement to an existing function
Milestone
21.10

Comments

@seunghwak
Copy link
Contributor

Describe the solution you'd like
RMM added cuda_stream_view (https://github.com/rapidsai/rmm/blob/branch-0.19/include/rmm/cuda_stream_view.hpp#L34)

This wraps a native CUDA stream with convenience functions, and we should switch to this new feature.

CUDA_TRY(cudaStreamSynchronize(handle.get_stream()));
=>
handle.get_stream_view().synchronize()

get_stream() call on raft::handle_t should be replaced with get_stream_view()

and thrust execution policy

rmm::exec_policy(handle_ptr_->get_stream())->on(handle_ptr_->get_stream())

can now be rmm::exec_policy(handle.get_stream_view()) for example.
@seunghwak seunghwak added the ? - Needs Triage Need team to review and classify label Feb 22, 2021
@seunghwak seunghwak mentioned this issue Feb 22, 2021
Merged
2 tasks
@BradReesWork BradReesWork added improvement Improvement / enhancement to an existing function and removed ? - Needs Triage Need team to review and classify labels Mar 10, 2021
@BradReesWork BradReesWork added this to the 0.20 milestone Mar 10, 2021
@github-actions
Copy link

github-actions bot commented Apr 9, 2021

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@BradReesWork BradReesWork changed the title [ENH] update cuGraph to use rmm's new cuda_stream_view [ENH] update and refactor all cuGraph to use rmm's new cuda_stream_view Jun 2, 2021
@BradReesWork BradReesWork modified the milestones: 21.06, 21.08 Jun 2, 2021
@ChuckHastings ChuckHastings mentioned this issue Jun 7, 2021
Merged
rapids-bot bot pushed a commit that referenced this issue Jun 15, 2021
@ChuckHastings
Fea cleanup stream part1 (#1653)
27444ed 
Addresses part of #1538 and #1422 

Breaking the work for these issues into smaller chunks to make it easier to test, review and approve.

Authors:
  - Chuck Hastings (https://github.com/ChuckHastings)

Approvers:
  - Seunghwa Kang (https://github.com/seunghwak)
  - Andrei Schaffer (https://github.com/aschaffer)

URL: #1653
@ChuckHastings ChuckHastings modified the milestones: 21.08, 21.10 Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function
Projects
None yet
Milestone
21.10
Development

No branches or pull requests
3 participants
@BradReesWork @ChuckHastings @seunghwak