Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] issue when importing the comms #2329

Closed
jnke2016 opened this issue Jun 2, 2022 · 0 comments · Fixed by #2402
Closed

[BUG] issue when importing the comms #2329

jnke2016 opened this issue Jun 2, 2022 · 0 comments · Fixed by #2402
Assignees
@jnke2016
Labels
bug Something isn't working
Milestone
22.08

Comments

@jnke2016
Copy link
Contributor

jnke2016 commented Jun 2, 2022

Describe the bug
A breaking change was introduced in 22.06 where the comms dir was moved from cugraph/cugraph/comms to cugraph/cugraph/dask/comms. This affect the way the comms are imported and break prior releases which are still importing the comms the old: way import cugraph.comms as Comms. When attempting to do so, the user would get the error below

import cugraph.comms as Comms
ModuleNotFoundError: No module named 'cugraph.comms'

Ideally we would like to not break our previous releases.
@jnke2016 jnke2016 added ? - Needs Triage Need team to review and classify bug Something isn't working labels Jun 2, 2022
@BradReesWork BradReesWork removed the ? - Needs Triage Need team to review and classify label Jul 1, 2022
@rlratzel rlratzel added this to the 22.08 milestone Jul 6, 2022
@jnke2016 jnke2016 mentioned this issue Jul 12, 2022
Merged
rapids-bot bot pushed a commit that referenced this issue Jul 21, 2022
@jnke2016
Remove the comms import from cugraph's init file (#2402)
f09c298 
A breaking change in 22.06 moved the functionalities of `comms` to `cugraph/dask` where it should belong as it is only part of the multi GPU API. However `cugraph/__init__.py` is still importing the the comms when it shouldn't.

This PR removes the `comms` import in `cugraph/__init__.py `

closes #2379
closes #2329

Authors:
  - Joseph Nke (https://github.com/jnke2016)

Approvers:
  - Rick Ratzel (https://github.com/rlratzel)

URL: #2402
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jnke2016 jnke2016

Labels
bug Something isn't working
Projects
None yet
Milestone
22.08
Development

Successfully merging a pull request may close this issue.

Remove the comms import from cugraph's init file jnke2016/cugraph
3 participants
@rlratzel @BradReesWork @jnke2016