Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA]: Update cugraph_dgl to use vector features added in 2882 #2968

Closed
2 tasks done
VibhuJawa opened this issue Nov 21, 2022 · 1 comment · Fixed by #3000
Closed
2 tasks done

[FEA]: Update cugraph_dgl to use vector features added in 2882 #2968

VibhuJawa opened this issue Nov 21, 2022 · 1 comment · Fixed by #3000
Assignees
@VibhuJawa
Labels
improvement Improvement / enhancement to an existing function
Milestone
23.04

Comments

@VibhuJawa
Copy link
Member

Is this a new feature, an improvement, or a change to existing functionality?

Improvement

How would you describe the priority of this feature request

High

Please provide a clear description of problem this feature solves

Update cugraph_dgl to use vector features added in #2882

Describe your ideal solution

Use the API calls here to use vector_properties or vector_property in the below places:

cugraph/python/cugraph/cugraph/gnn/dgl_extensions/cugraph_store.py

Line 138 in aab7103

self.gdata.add_edge_data(

cugraph/python/cugraph/cugraph/gnn/dgl_extensions/cugraph_store.py

Line 94 in aab7103

self.gdata.add_vertex_data(df, vertex_col_name=node_col_name, type_name=ntype)

Describe any alternatives you have considered

NA

Additional context

No response

Code of Conduct

  • I agree to follow cuGraph's Code of Conduct
  • I have searched the open feature requests and have found no duplicates for this feature request
@VibhuJawa VibhuJawa added the improvement Improvement / enhancement to an existing function label Nov 21, 2022
@VibhuJawa VibhuJawa added this to the 23.02 milestone Nov 29, 2022
@VibhuJawa VibhuJawa self-assigned this Nov 29, 2022
@VibhuJawa VibhuJawa mentioned this issue Nov 29, 2022
Closed
@VibhuJawa VibhuJawa changed the title [FEA]: Update cugraph_dgl to use vector features added in [FEA]: Update cugraph_dgl to use vector features added in 2882 Nov 29, 2022
@VibhuJawa VibhuJawa mentioned this issue Nov 30, 2022
Merged
@VibhuJawa
Copy link
Member Author

Will be closed by PR: #3000

@VibhuJawa VibhuJawa modified the milestones: 23.02, 23.04 Jan 4, 2023
@rapids-bot rapids-bot bot closed this as completed in #3000 Jan 4, 2023
rapids-bot bot pushed a commit that referenced this issue Jan 4, 2023
@VibhuJawa
Update cugraph_dgl to use vector_properties (#3000)
6920089 
This PR closes #2968  


Verified that we work on #2925

Authors:
  - Vibhu Jawa (https://github.com/VibhuJawa)
  - Rick Ratzel (https://github.com/rlratzel)

Approvers:
  - Rick Ratzel (https://github.com/rlratzel)

URL: #3000
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VibhuJawa VibhuJawa

Labels
improvement Improvement / enhancement to an existing function
Projects
None yet
Milestone
23.04
Development

Successfully merging a pull request may close this issue.

[REVIEW] Update cugraph_dgl to use vector_properties VibhuJawa/cugraph
1 participant
@VibhuJawa