Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI crashes on pytest teardown #3124

Closed
rlratzel opened this issue Jan 10, 2023 · 0 comments · Fixed by #3167
Closed

CI crashes on pytest teardown #3124

rlratzel opened this issue Jan 10, 2023 · 0 comments · Fixed by #3167
Assignees
@rlratzel @ChuckHastings
Labels
bug Something isn't working
Milestone
23.02

Comments

@rlratzel
Copy link
Contributor

rlratzel commented Jan 10, 2023 •
edited
Loading

CI crashes with a seg fault on pytest teardown.

This is blocking cugraph from merging PRs.
@rlratzel rlratzel added this to the 23.02 milestone Jan 10, 2023
@rlratzel rlratzel added the bug Something isn't working label Jan 10, 2023
@rlratzel rlratzel mentioned this issue Jan 22, 2023
Merged
@rapids-bot rapids-bot bot closed this as completed in #3167 Feb 3, 2023
rapids-bot bot pushed a commit that referenced this issue Feb 3, 2023
@rlratzel
Fixes devices vector alloc to fix seg fault, removes unused RAFT code…
f780add 
… in PLC, re-enables full CI testing (#3167)

closes #3124 

* Adds check to avoid allocating and copying zero-length device vectors.  This prevents the seg fault shown below.
* Removes the special case to ignore seg faults in CI scripts
* Adds a test to reproduce seg fault locally (see output below).

This PR addresses the problem shown below:
```
================================= test session starts =================================
platform linux -- Python 3.8.15, pytest-7.2.0, pluggy-1.0.0 -- /opt/conda/envs/test/bin/python3.8
cachedir: .pytest_cache
rapids_pytest_benchmark: 0.0.14
benchmark: 3.2.3 (defaults: timer=time.perf_counter disable_gc=False min_rounds=5 min_time=0.000005 max_time=1.0 calibration_precision=10 warmup=False warmup_iterations=100000)
rootdir: /cugraph/python/pylibcugraph, configfile: pytest.ini
plugins: cov-4.0.0, rapids-pytest-benchmark-0.0.14, benchmark-3.2.3
collected 9 items / 8 deselected / 1 selected

python/pylibcugraph/pylibcugraph/tests/test_graph_sg.py::test_SGGraph_create_from_cudf
get edgelist...edgelist =     src  dst  wgt
0    0    1  0.0
1    1    2  0.1
2    2    4  0.2
done
create Graph...done
created SGGraph plc_graph=<pylibcugraph.graphs.SGGraph object at 0x7fb7e35f30f0>
PASSED

=========================== 1 passed, 8 deselected in 1.69s ===========================
Segmentation fault (core dumped)
```

@cjnolet found a work-around for us, so this should pass CI and can be merged after rapidsai/raft#1224

Authors:
  - Rick Ratzel (https://github.com/rlratzel)
  - Chuck Hastings (https://github.com/ChuckHastings)
  - Corey J. Nolet (https://github.com/cjnolet)
  - AJ Schmidt (https://github.com/ajschmidt8)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Chuck Hastings (https://github.com/ChuckHastings)
  - Brad Rees (https://github.com/BradReesWork)

URL: #3167
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rlratzel rlratzel

@ChuckHastings ChuckHastings

Labels
bug Something isn't working
Projects
None yet
Milestone
23.02
2 participants
@rlratzel @ChuckHastings