Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] CSC Order Causes Issues with OGB Datasets #3969

Closed
alexbarghi-nv opened this issue Nov 1, 2023 · 0 comments · Fixed by #3980
Closed

[BUG] CSC Order Causes Issues with OGB Datasets #3969

alexbarghi-nv opened this issue Nov 1, 2023 · 0 comments · Fixed by #3980
Assignees
@alexbarghi-nv
Labels
breaking Breaking change CRITICAL BUG! BUG that needs to be FIX NOW !!!!
Milestone
23.12

Comments

@alexbarghi-nv
Copy link
Member

While CSC order is technically correct, it does not match the order of the ogb datasets, which specify CSR order. This has caused numerous issues with the examples based on OGB datasets, which are also the templates for most user datasets. To avoid user confusion, the default order should be reverted to CSR.
@alexbarghi-nv alexbarghi-nv self-assigned this Nov 1, 2023
@alexbarghi-nv alexbarghi-nv added breaking Breaking change CRITICAL BUG! BUG that needs to be FIX NOW !!!! labels Nov 1, 2023
@alexbarghi-nv alexbarghi-nv added this to the 23.12 milestone Nov 1, 2023
@alexbarghi-nv alexbarghi-nv mentioned this issue Nov 6, 2023
Merged
@rapids-bot rapids-bot bot closed this as completed in #3980 Nov 7, 2023
rapids-bot bot pushed a commit that referenced this issue Nov 7, 2023
@alexbarghi-nv
[BUG] Restore the original default order of CSR, which does not rever…
a3cda5d 
…se edges in cuGraph-PyG (#3980)

OGB and many other datasets express the edge index in CSR order, but in release 23.10, the default order was changed to CSC, which broke downstream workflows.  This PR restores the original default, which should be acceptable for the most common datasets, and familiar to most PyG users.

Closes #3969

Authors:
  - Alex Barghi (https://github.com/alexbarghi-nv)

Approvers:
  - Tingyu Wang (https://github.com/tingyu66)
  - Rick Ratzel (https://github.com/rlratzel)

URL: #3980
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexbarghi-nv alexbarghi-nv

Labels
breaking Breaking change CRITICAL BUG! BUG that needs to be FIX NOW !!!!
Projects
None yet
Milestone
23.12
1 participant
@alexbarghi-nv