[REVIEW] Expose resolution (gamma) parameter in Louvain #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…here it will be used
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
1) Reformulated the delta_Q computation, should actually
match the change in modularity now
2) Refactored computing delta_Q into a separate function
3) Expose detail APIs for computing Q and delta_Q
4) Add unit test that specifically tests modularity
and delta modularity functions for some simple
graphs.
ChuckHastings
changed the title
Codecov Report
@@ Coverage Diff @@
## branch-0.15 #1034 +/- ##
===============================================
+ Coverage 70.54% 70.57% +0.02%
===============================================
Files 54 54
Lines 1996 1998 +2
===============================================
+ Hits 1408 1410 +2
Misses 588 588
Continue to review full report at Codecov.
|
|
rerun tests |
aschaffer
approved these changes
Aug 5, 2020
rlratzel
approved these changes
Aug 5, 2020
| int max_iter = 100); | ||
| vertex_t *louvain_parts, | ||
| int max_iter = 100, | ||
| weight_t resolution = weight_t{1}); |
There was a problem hiding this comment.
I'm assuming this default value is fine for ECG?
There was a problem hiding this comment.
The default of 1 makes Louvain behave just as it did before - which should be fine for ECG.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a resolution parameter (gamma in the mathematical formulation) to the Louvain score.
Closes #674
Includes an update to the delta_Q computation