Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] add max_vertex_id for mnmg local data compute #1062

Merged
merged 4 commits into from
Aug 13, 2020
Merged

[REVIEW] add max_vertex_id for mnmg local data compute #1062

merged 4 commits into from
Aug 13, 2020

Conversation

Iroy30
Copy link
Contributor

@Iroy30 Iroy30 commented Aug 11, 2020

No description provided.

@Iroy30 Iroy30 requested a review from a team as a code owner August 11, 2020 05:03
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2020 •
edited
Loading

Codecov Report

Merging #1062 into branch-0.15 will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.15    #1062      +/-   ##
===============================================
+ Coverage        70.70%   70.82%   +0.11%     
===============================================
  Files               54       54              
  Lines             1997     2005       +8     
===============================================
+ Hits              1412     1420       +8     
  Misses             585      585
Impacted Files Coverage Δ
python/cugraph/dask/common/input_utils.py 97.08% <100.00%> (+0.18%) ⬆️
python/cugraph/_version.py 44.80% <0.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4492e75...73fbde0. Read the comment docs.

@BradReesWork BradReesWork added this to the 0.15 milestone Aug 11, 2020
BradReesWork
BradReesWork approved these changes Aug 11, 2020
View reviewed changes
Copy link
Member

@BradReesWork BradReesWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the use of .iloc[-1], but I always think that reads wrong

@Iroy30
Copy link
Contributor Author

Iroy30 commented Aug 11, 2020

rerun tests

@BradReesWork
Copy link
Member

rerun tests

@Iroy30
Copy link
Contributor Author

Iroy30 commented Aug 13, 2020

rerun tests

@BradReesWork BradReesWork merged commit 01132a4 into rapidsai:branch-0.15 Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BradReesWork BradReesWork BradReesWork approved these changes

@aschaffer aschaffer aschaffer approved these changes

@ChuckHastings ChuckHastings ChuckHastings approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.15
Development

Successfully merging this pull request may close these issues.
5 participants
@Iroy30 @codecov-commenter @BradReesWork @aschaffer @ChuckHastings