Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Updating test and adding doc #1129

Merged
merged 42 commits into from
Sep 3, 2020
Merged

[REVIEW] Updating test and adding doc #1129

merged 42 commits into from
Sep 3, 2020

Conversation

BradReesWork
Copy link
Member

@BradReesWork BradReesWork commented Aug 28, 2020 •
edited
Loading

Centralizing tests to a small common set of files

Adding additional doc pages

closes #1112
closes #305

@BradReesWork BradReesWork added this to the 0.16 milestone Aug 28, 2020
@BradReesWork BradReesWork requested a review from a team as a code owner August 28, 2020 18:43
@BradReesWork BradReesWork marked this pull request as draft August 28, 2020 18:43
@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@BradReesWork BradReesWork self-assigned this Aug 28, 2020
@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@BradReesWork BradReesWork changed the title [WIP] Updating test and adding doc [REVIEW] Updating test and adding doc Aug 31, 2020
@BradReesWork BradReesWork marked this pull request as ready for review August 31, 2020 15:28
@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@BradReesWork
Copy link
Member Author

rerun tests

2 similar comments
@ajschmidt8
Copy link
Member

rerun tests

@BradReesWork
Copy link
Member Author

rerun tests

@ajschmidt8
Copy link
Member

rerun tests

@BradReesWork
Copy link
Member Author

rerun tests

afender
afender reviewed Sep 3, 2020
View reviewed changes
datasets/karate-disjoint.csv Show resolved Hide resolved
docs/source/cugraph_blogs.rst Outdated Show resolved Hide resolved
docs/source/cugraph_ref.rst Show resolved Hide resolved
python/cugraph/tests/utils.py Show resolved Hide resolved
docs/source/cugraph_blogs.rst Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2020 •
edited
Loading

Codecov Report

Merging #1129 into branch-0.16 will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.16    #1129      +/-   ##
===============================================
+ Coverage        72.37%   72.39%   +0.02%     
===============================================
  Files               56       56              
  Lines             2132     2134       +2     
===============================================
+ Hits              1543     1545       +2     
  Misses             589      589
Impacted Files Coverage Δ
python/cugraph/community/ecg.py 100.00% <ø> (ø)
python/cugraph/layout/force_atlas2.py 60.00% <ø> (ø)
python/cugraph/structure/graph.py 80.22% <ø> (ø)
python/cugraph/_version.py 44.80% <0.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5b903d...9f645f4. Read the comment docs.

@BradReesWork BradReesWork merged commit e46d1be into rapidsai:branch-0.16 Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlratzel rlratzel rlratzel approved these changes

@afender afender afender approved these changes

@Iroy30 Iroy30 Awaiting requested review from Iroy30

Assignees

@BradReesWork BradReesWork

Labels
None yet
Projects
None yet
Milestone
0.16
Development

Successfully merging this pull request may close these issues.

[DOC] README issues [FEA] Status of disconnected graph support in cuGraph
6 participants
@BradReesWork @GPUtester @ajschmidt8 @codecov-commenter @rlratzel @afender