Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Fix style checker #1131

Merged
merged 3 commits into from
Sep 1, 2020
Merged

[REVIEW] Fix style checker #1131

merged 3 commits into from
Sep 1, 2020

Conversation

raydouglass
Copy link
Member

Do not merge

@raydouglass raydouglass requested a review from a team as a code owner September 1, 2020 17:16
@raydouglass raydouglass self-assigned this Sep 1, 2020
@raydouglass raydouglass requested a review from a team as a code owner September 1, 2020 17:18
@raydouglass raydouglass changed the title [DO NOT MERGE] Style error [skip-ci-changelog] [REVIEW] Fix style checker Sep 1, 2020
@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

rlratzel
rlratzel requested changes Sep 1, 2020
View reviewed changes
ci/checks/style.sh Show resolved Hide resolved
rlratzel
rlratzel approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comment, very helpful

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2020 •
edited
Loading

Codecov Report

Merging #1131 into branch-0.16 will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.16    #1131      +/-   ##
===============================================
+ Coverage        72.37%   72.39%   +0.02%     
===============================================
  Files               56       56              
  Lines             2132     2134       +2     
===============================================
+ Hits              1543     1545       +2     
  Misses             589      589
Impacted Files Coverage Δ
python/cugraph/_version.py 44.80% <0.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5b903d...4a684b3. Read the comment docs.

@BradReesWork BradReesWork added this to the 0.16 milestone Sep 1, 2020
@BradReesWork BradReesWork merged commit 1a1d434 into rapidsai:branch-0.16 Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlratzel rlratzel rlratzel approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@BradReesWork BradReesWork BradReesWork approved these changes

Assignees

@raydouglass raydouglass

Labels
None yet
Projects
None yet
Milestone
0.16
Development

Successfully merging this pull request may close these issues.
6 participants
@raydouglass @GPUtester @codecov-commenter @rlratzel @ajschmidt8 @BradReesWork