Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] doc and API fixes #1144

Merged
merged 10 commits into from
Sep 15, 2020
Merged

[REVIEW] doc and API fixes #1144

merged 10 commits into from
Sep 15, 2020

Conversation

BradReesWork
Copy link
Member

Updated docs to fix missing arguments
Added NetworkX like API

@BradReesWork BradReesWork requested a review from a team as a code owner September 15, 2020 16:58
@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@BradReesWork BradReesWork added this to the 0.16 milestone Sep 15, 2020
@BradReesWork BradReesWork changed the title [WIP][skip-ci] doc and API fixes [REVIEW] doc and API fixes Sep 15, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2020

Codecov Report

Merging #1144 into branch-0.16 will increase coverage by 0.01%.
The diff coverage is 75.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.16    #1144      +/-   ##
===============================================
+ Coverage        72.37%   72.39%   +0.01%     
===============================================
  Files               56       56              
  Lines             2132     2137       +5     
===============================================
+ Hits              1543     1547       +4     
- Misses             589      590       +1     
Impacted Files Coverage Δ
...ython/cugraph/centrality/betweenness_centrality.py 98.03% <ø> (ø)
python/cugraph/community/ktruss_subgraph.py 85.71% <ø> (ø)
python/cugraph/community/subgraph_extraction.py 93.33% <ø> (ø)
python/cugraph/community/triangle_count.py 85.71% <ø> (ø)
python/cugraph/structure/convert_matrix.py 88.88% <ø> (ø)
python/cugraph/structure/graph.py 80.22% <ø> (ø)
python/cugraph/link_prediction/jaccard.py 86.36% <50.00%> (-3.64%) ⬇️
python/cugraph/__init__.py 100.00% <100.00%> (ø)
python/cugraph/link_prediction/__init__.py 100.00% <100.00%> (ø)
python/cugraph/_version.py 44.80% <0.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf6c27d...3fca967. Read the comment docs.

Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I had one minor suggestion/question which need not hold up my approval.

python/cugraph/community/triangle_count.py Outdated Show resolved Hide resolved
@BradReesWork
Copy link
Member Author

rerun tests

Copy link
Contributor

@Iroy30 Iroy30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@afender afender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -984,6 +984,11 @@ def degrees(self, vertex_subset=None):
Returns
-------
df : cudf.DataFrame
GPU DataFrame of size N (the default) or the size of the given
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
GPU DataFrame of size N (the default) or the size of the given
GPU DataFrame of size V (the default) or the size of the given

@BradReesWork BradReesWork merged commit a24016d into rapidsai:branch-0.16 Sep 15, 2020
@BradReesWork BradReesWork deleted the 0.16-doc-fixes branch September 15, 2020 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants