Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] pass size_t* instead of int_t[] for raft allgatherv's input parameter displs #1158

Merged
merged 5 commits into from
Sep 25, 2020
Merged

[REVIEW] pass size_t* instead of int_t[] for raft allgatherv's input parameter displs #1158

merged 5 commits into from
Sep 25, 2020

Conversation

seunghwak
Copy link
Contributor

@seunghwak seunghwak commented Sep 24, 2020 •
edited
Loading

RAFT allgatherv is updated to take size_t* instead of int_t[] for displs, cuGraph needs to updated accordingly.

@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@BradReesWork BradReesWork added this to the 0.16 milestone Sep 24, 2020
@seunghwak seunghwak changed the title [REVIEW][skip-ci] pass size_t[] instead of int_t[] for raft allgatherv's input parameter displs [REVIEW][skip-ci] pass size_t* instead of int_t[] for raft allgatherv's input parameter displs Sep 24, 2020
@seunghwak seunghwak marked this pull request as ready for review September 24, 2020 20:26
@seunghwak seunghwak requested review from a team as code owners September 24, 2020 20:26
@seunghwak seunghwak changed the title [REVIEW][skip-ci] pass size_t* instead of int_t[] for raft allgatherv's input parameter displs [REVIEW] pass size_t* instead of int_t[] for raft allgatherv's input parameter displs Sep 24, 2020
@BradReesWork
Copy link
Member

rerun tests

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2020 •
edited
Loading

Codecov Report

Merging #1158 into branch-0.16 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           branch-0.16    #1158   +/-   ##
============================================
  Coverage        73.44%   73.44%           
============================================
  Files               60       60           
  Lines             2335     2335           
============================================
  Hits              1715     1715           
  Misses             620      620

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85ec558...e11dd31. Read the comment docs.

@BradReesWork BradReesWork merged commit 6e36fa1 into rapidsai:branch-0.16 Sep 25, 2020
@seunghwak seunghwak deleted the bug_allgatherv_type branch October 3, 2020 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BradReesWork BradReesWork BradReesWork approved these changes

@afender afender afender approved these changes

@aschaffer aschaffer Awaiting requested review from aschaffer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.16
Development

Successfully merging this pull request may close these issues.
5 participants
@seunghwak @GPUtester @BradReesWork @codecov-commenter @afender