Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] BUG fix misspelling of function calls in asserts causing debug build to fail #1166

Conversation

ChuckHastings
Copy link
Collaborator

Some of the pattern accelerator calls have the misspelled calls in assert messages.

@ChuckHastings ChuckHastings requested a review from a team as a code owner September 28, 2020 18:46
@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing my mistakes :-)

@ChuckHastings
Copy link
Collaborator Author

rerun tests

1 similar comment
@ChuckHastings
Copy link
Collaborator Author

rerun tests

@abellina
Copy link

@ChuckHastings sorry I am not familiar with this change, maybe I was tagged by mistake.

@ChuckHastings
Copy link
Collaborator Author

@ChuckHastings sorry I am not familiar with this change, maybe I was tagged by mistake.

No worries. @BradReesWork probably tagged you accidentally.

@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2020

Codecov Report

Merging #1166 into branch-0.16 will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.16    #1166      +/-   ##
===============================================
+ Coverage        57.71%   57.75%   +0.03%     
===============================================
  Files               61       61              
  Lines             2410     2412       +2     
===============================================
+ Hits              1391     1393       +2     
  Misses            1019     1019              
Impacted Files Coverage Δ
python/cugraph/_version.py 45.51% <0.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1becb6f...9fa9b88. Read the comment docs.

@BradReesWork BradReesWork merged commit 213c482 into rapidsai:branch-0.16 Sep 29, 2020
@ChuckHastings ChuckHastings deleted the bug_pattern_accelerator_debug_build branch February 10, 2021 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants