Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] ENH Added min CUDA version check to MG Louvain #1222

Merged
merged 7 commits into from
Oct 15, 2020
Merged

[REVIEW] ENH Added min CUDA version check to MG Louvain #1222

merged 7 commits into from
Oct 15, 2020

Conversation

rlratzel
Copy link
Contributor

Added a check for CUDA runtime version to be >= 10.2 to the MG Louvain API, which makes for a more user-friendly error message.

@rlratzel rlratzel requested a review from Iroy30 October 14, 2020 15:52
@rlratzel rlratzel requested a review from a team as a code owner October 14, 2020 15:52
@rlratzel rlratzel self-assigned this Oct 14, 2020
@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@BradReesWork BradReesWork added this to the 0.16 milestone Oct 14, 2020
@codecov-io
Copy link

codecov-io commented Oct 14, 2020 •
edited
Loading

Codecov Report

Merging #1222 into branch-0.16 will decrease coverage by 0.13%.
The diff coverage is 23.07%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.16    #1222      +/-   ##
===============================================
- Coverage        56.72%   56.59%   -0.14%     
===============================================
  Files               62       62              
  Lines             2549     2564      +15     
===============================================
+ Hits              1446     1451       +5     
- Misses            1103     1113      +10
Impacted Files Coverage Δ
python/cugraph/utilities/utils.py 69.23% <20.00%> (-11.73%) ⬇️
python/cugraph/dask/community/louvain.py 33.33% <33.33%> (ø)
python/cugraph/_version.py 44.80% <0.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d83cff7...fd48e9c. Read the comment docs.

@rlratzel
Copy link
Contributor Author

rerun tests

@rlratzel
Copy link
Contributor Author

rerun tests

1 similar comment
@BradReesWork
Copy link
Member

rerun tests

@rlratzel
Copy link
Contributor Author

rerun tests

reason: a git clone step failed

@rlratzel rlratzel requested a review from a team as a code owner October 15, 2020 02:33
@rlratzel
Copy link
Contributor Author

rerun tests

reason: FATAL: Could not pull image: gpuci/rapidsai:0.16-cuda10.1-devel-ubuntu16.04-py3.7

@mike-wendt
Copy link
Contributor

FYI gpuCI/cugraph/pr-builder is showing failure, but do not retry just yet. It is marked as failed due to killing the retried job. It will update when this run is completed

@mike-wendt
Copy link
Contributor

mike-wendt commented Oct 15, 2020 •
edited
Loading

Looks like test failures with CUDA 11 testing; your judgement call on how to proceed @rlratzel @BradReesWork

FWIW they look notebook related

@BradReesWork BradReesWork merged commit 14606fc into rapidsai:branch-0.16 Oct 15, 2020
@rlratzel rlratzel deleted the branch-0.16-mincudaversioncheck branch December 9, 2020 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BradReesWork BradReesWork BradReesWork approved these changes

@Iroy30 Iroy30 Iroy30 approved these changes

@afender afender afender approved these changes

Assignees

@rlratzel rlratzel

Labels
None yet
Projects
None yet
Milestone
0.16
Development

Successfully merging this pull request may close these issues.
7 participants
@rlratzel @GPUtester @codecov-io @BradReesWork @mike-wendt @Iroy30 @afender