Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW][skip-ci-changelog] Include doxygen for new and clean conda environments #1272

Merged
merged 1 commit into from
Nov 17, 2020
Merged

[REVIEW][skip-ci-changelog] Include doxygen for new and clean conda environments #1272

merged 1 commit into from
Nov 17, 2020

Conversation

jpurviance
Copy link
Contributor

Tried building cugraph from source today with ./build.sh. I built my conda environment from conda/environments/cugraph_dev_cuda11.0.yml

I ran into docs build target failing because doxygen was not in the environment:

Scanning dependencies of target docs_cugraph
[100%] Generating CUGRAPH_DOXYGEN
/bin/sh: 1: doxygen: not found
CMakeFiles/docs_cugraph.dir/build.make:79: recipe for target 'CUGRAPH_DOXYGEN' failed
make[3]: *** [CUGRAPH_DOXYGEN] Error 127
CMakeFiles/Makefile2:217: recipe for target 'CMakeFiles/docs_cugraph.dir/all' failed
make[2]: *** [CMakeFiles/docs_cugraph.dir/all] Error 2
CMakeFiles/Makefile2:224: recipe for target 'CMakeFiles/docs_cugraph.dir/rule' failed
make[1]: *** [CMakeFiles/docs_cugraph.dir/rule] Error 2
Makefile:207: recipe for target 'docs_cugraph' failed

@jpurviance jpurviance requested a review from a team as a code owner November 14, 2020 04:23
@GPUtester
Copy link
Contributor

Can one of the admins verify this patch?

2 similar comments
@GPUtester
Copy link
Contributor

Can one of the admins verify this patch?

@GPUtester
Copy link
Contributor

Can one of the admins verify this patch?

@BradReesWork
Copy link
Member

@jpurviance great catch

@BradReesWork BradReesWork added 3 - Ready for Review improvement Improvement / enhancement to an existing function labels Nov 16, 2020
@BradReesWork BradReesWork added this to the 0.17 milestone Nov 16, 2020
@BradReesWork
Copy link
Member

ok to test

@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@BradReesWork BradReesWork changed the title Include doxygen for new and clean conda environments [REVIEW][skip-ci-changelog] Include doxygen for new and clean conda environments Nov 16, 2020
@BradReesWork
Copy link
Member

rerun test

rlratzel
rlratzel approved these changes Nov 16, 2020
View reviewed changes
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this.

@BradReesWork
Copy link
Member

ok to test

@BradReesWork BradReesWork merged commit 4cf595f into rapidsai:branch-0.17 Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BradReesWork BradReesWork BradReesWork approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@rlratzel rlratzel rlratzel approved these changes

@afender afender Awaiting requested review from afender

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function
Projects
None yet
Milestone
0.17
Development

Successfully merging this pull request may close these issues.
5 participants
@jpurviance @GPUtester @BradReesWork @rlratzel @ajschmidt8