[REVIEW] FEA generic from_edgelist() and from_adjlist() APIs #1274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
BradReesWork
added
the
improvement
Iroy30
reviewed
Nov 19, 2020
rlratzel
changed the title
|
rerun tests |
…branch-0.17-genericfromedgelist
BradReesWork
approved these changes
Nov 23, 2020
afender
approved these changes
Nov 23, 2020
There was a problem hiding this comment.
Thanks. Initial naming came from consistency with
https://networkx.org/documentation/stable/reference/generated/networkx.convert_matrix.from_pandas_edgelist.html
…genericfromedgelist, added code and tests for from_adjlist().
…genericfromedgelist
rlratzel
changed the title
Codecov Report
@@ Coverage Diff @@
## branch-0.17 #1274 +/- ##
===============================================
+ Coverage 57.92% 58.05% +0.12%
===============================================
Files 65 65
Lines 2800 2837 +37
===============================================
+ Hits 1622 1647 +25
- Misses 1178 1190 +12
Continue to review full report at Codecov.
|
|
rerun tests |
BradReesWork
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation and tests for generic
from_edgelist()andfrom_adjlist()APIs, which can be used in place offrom_cudf_edgelist()andfrom_pandas_edgelist(), etc. to make for more common code across different input data types.closes #1141