-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Updates to support nightly MG test automation #1308
Merged
rapids-bot
merged 6 commits into
rapidsai:branch-0.18
from
rlratzel:branch-0.18-mgtestfixes
Jan 4, 2021
Merged
[REVIEW] Updates to support nightly MG test automation #1308
rapids-bot
merged 6 commits into
rapidsai:branch-0.18
from
rlratzel:branch-0.18-mgtestfixes
Jan 4, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ys use all GPUs) and instead vary GPU count with CUDA_VISIBLE_DEVICES env var, added call to wait_for_workers() for MG test setups.
…" and marked certain MG tests accordingly, and added None as an option to use all visible. This allows nightly tests to set "not preset_gpu_count" to only run on all visible GPUs.
xcadet
reviewed
Dec 10, 2020
BradReesWork
added
2 - In Progress
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
labels
Dec 11, 2020
rlratzel
changed the title
[WIP][skip-ci] Updates to support nightly MG test automation
[REVIEW] ENH Updates to support nightly MG test automation
Dec 29, 2020
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-0.18 #1308 +/- ##
===============================================
- Coverage 60.38% 60.21% -0.17%
===============================================
Files 67 67
Lines 3029 3049 +20
===============================================
+ Hits 1829 1836 +7
- Misses 1200 1213 +13
Continue to review full report at Codecov.
|
Iroy30
reviewed
Dec 30, 2020
Iroy30
reviewed
Dec 30, 2020
…y adding a teardown utility.
rlratzel
changed the title
[REVIEW] ENH Updates to support nightly MG test automation
[REVIEW] Updates to support nightly MG test automation
Dec 30, 2020
Iroy30
approved these changes
Jan 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes various updates to support nightly automated MG test runs, including:
CUDA_VISIBLE_DEVICES
env var.pytest -m "not preset_gpu_count" ...
client.wait_for_workers()
call to various setups to both match the approach taken by theMGContext
class, and to ensure workers are running. This seemed to increase reliability in the test runs.MGContext
class or theclient_connection
pytest fixture in these tests, since they both aim to accomplish the same thing.