Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create cuGraph developers guide #1431

Merged

Conversation

ChuckHastings
Copy link
Collaborator

We have long needed a developer's guide. This PR creates one. The expectation is that this document will be adapted over time.

I have copied the version from cuDF, edited things to make it cuGraph focused. There are documentation holes here that will need to eventually be filled in. However, it's probably useful to get something with holes in it that is approved so we can move forward with some documented standard.

@ChuckHastings ChuckHastings requested a review from a team as a code owner March 1, 2021 17:12
@rlratzel rlratzel added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 1, 2021
@BradReesWork BradReesWork added this to the 0.19 milestone Mar 1, 2021
@BradReesWork BradReesWork added doc Documentation and removed improvement Improvement / enhancement to an existing function labels Mar 4, 2021
@BradReesWork
Copy link
Member

rerun tests

@codecov-io
Copy link

Codecov Report

Merging #1431 (69e64b6) into branch-0.19 (89bffa5) will decrease coverage by 0.60%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #1431      +/-   ##
===============================================
- Coverage        60.72%   60.12%   -0.61%     
===============================================
  Files               70       70              
  Lines             3132     3132              
===============================================
- Hits              1902     1883      -19     
- Misses            1230     1249      +19     
Impacted Files Coverage Δ
python/cugraph/community/leiden.py 35.71% <0.00%> (-57.15%) ⬇️
python/cugraph/community/ecg.py 54.54% <0.00%> (-45.46%) ⬇️
python/cugraph/community/louvain.py 57.14% <0.00%> (-35.72%) ⬇️
python/cugraph/utilities/utils.py 70.86% <0.00%> (-0.79%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89bffa5...69e64b6. Read the comment docs.

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit b7e6809 into rapidsai:branch-0.19 Mar 4, 2021
@ChuckHastings ChuckHastings deleted the fea_C++_coding_standards branch July 28, 2021 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants