Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update graph primitives to support vertex-tagging in frontier expansion #1551

Merged
merged 27 commits into from
May 14, 2021

Conversation

seunghwak
Copy link
Contributor

@seunghwak seunghwak commented Apr 22, 2021

To get early feedback and to create a baseline weakly-connected-component PR dependent on this PR.
This PR requires C++17 and will not compile till #1528 gets resolved.

Tagging vertex IDs with root IDs is necessary in

multi-source BFS, k-hop neighbors, and the newly designed weakly-connected-component algorithm based on multi-root collaborative frontier expansion.

To fully support multi-source BFS & k-hop neighbors, we also need to store/query properties for (vertex, tag) pairs, and this update will be added in a future PR.

@seunghwak seunghwak requested a review from a team as a code owner April 22, 2021 16:05
@BradReesWork BradReesWork added 3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 26, 2021
@BradReesWork BradReesWork added this to the 0.20 milestone Apr 26, 2021
Copy link
Collaborator

@ChuckHastings ChuckHastings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far.

@seunghwak seunghwak changed the title [skip-ci] Update graph primitives to support vertex-tagging in frontier expansion Update graph primitives to support vertex-tagging in frontier expansion Apr 26, 2021
@seunghwak seunghwak self-assigned this Apr 28, 2021
@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2021

Codecov Report

Merging #1551 (c8eddd1) into branch-0.20 (250f2c8) will decrease coverage by 1.13%.
The diff coverage is 62.32%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.20    #1551      +/-   ##
===============================================
- Coverage        61.04%   59.90%   -1.14%     
===============================================
  Files               73       79       +6     
  Lines             3219     3482     +263     
===============================================
+ Hits              1965     2086     +121     
- Misses            1254     1396     +142     
Impacted Files Coverage Δ
python/cugraph/__init__.py 100.00% <ø> (ø)
python/cugraph/components/connectivity.py 95.65% <ø> (ø)
python/cugraph/dask/centrality/katz_centrality.py 29.16% <ø> (ø)
python/cugraph/dask/link_analysis/pagerank.py 21.87% <0.00%> (ø)
python/cugraph/dask/traversal/bfs.py 25.00% <0.00%> (-2.59%) ⬇️
python/cugraph/traversal/bfs.py 89.65% <ø> (+2.69%) ⬆️
python/cugraph/traversal/ms_bfs.py 11.11% <ø> (ø)
python/cugraph/traversal/sssp.py 92.85% <ø> (-0.78%) ⬇️
python/cugraph/traversal/traveling_salesperson.py 84.61% <ø> (ø)
python/cugraph/tree/minimum_spanning_tree.py 85.36% <ø> (ø)
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c42957...c8eddd1. Read the comment docs.

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 2871281 into rapidsai:branch-0.20 May 14, 2021
@seunghwak seunghwak deleted the enh_traversal_prims branch June 24, 2021 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants