Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] add multi-column support in algorithms - part 1 #1559

Merged
merged 12 commits into from
May 6, 2021

Conversation

Iroy30
Copy link
Contributor

@Iroy30 Iroy30 commented Apr 26, 2021

Enable multi-column support in algorithms.
This PR updates:

  • Katz_centrality
  • Egonet
  • SSSP
  • Subgraph_extraction
  • K_core
  • Lap
  • RandonWalk - added test, waiting for Joseph's wrapper updates

@Iroy30 Iroy30 requested a review from a team as a code owner April 26, 2021 14:40
@Iroy30 Iroy30 changed the title [WIP] add multi-column support in algorithms [REVIEW] add multi-column support in algorithms Apr 27, 2021
@BradReesWork BradReesWork added 3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 27, 2021
@BradReesWork BradReesWork added this to the 0.20 milestone Apr 27, 2021
@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-0.20@1c7142e). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head f3c1029 differs from pull request most recent head 0a6d3b2. Consider uploading reports for the commit 0a6d3b2 to get more accurate results
Impacted file tree graph

@@              Coverage Diff               @@
##             branch-0.20    #1559   +/-   ##
==============================================
  Coverage               ?   60.27%           
==============================================
  Files                  ?       77           
  Lines                  ?     3391           
  Branches               ?        0           
==============================================
  Hits                   ?     2044           
  Misses                 ?     1347           
  Partials               ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c7142e...0a6d3b2. Read the comment docs.

@Iroy30 Iroy30 changed the title [REVIEW] add multi-column support in algorithms [REVIEW] add multi-column support in algorithms - part 1 May 3, 2021
@@ -106,7 +106,13 @@ def katz_centrality(

if nstart is not None:
if G.renumbered is True:
nstart = G.add_internal_vertex_id(nstart, 'vertex', 'vertex')
print(G.renumber_map.implementation.col_names)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the print?

print(G.renumber_map.implementation.col_names)
if len(G.renumber_map.implementation.col_names) > 1:
cols = nstart.columns[:-2]
print(cols)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here. Why printing column names?

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 924f678 into rapidsai:branch-0.20 May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants