Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable correctness check in C++ testing by default. #1560

Merged
merged 2 commits into from
Apr 29, 2021

Conversation

seunghwak
Copy link
Contributor

@seunghwak seunghwak commented Apr 26, 2021

Correctness check in C++ testing was disabled by default. Enable by default.

@seunghwak seunghwak requested a review from a team as a code owner April 26, 2021 17:08
@seunghwak seunghwak added 3 - Ready for Review bug Something isn't working non-breaking Non-breaking change labels Apr 26, 2021
@BradReesWork BradReesWork added this to the 0.20 milestone Apr 26, 2021
@seunghwak
Copy link
Contributor Author

rerun tests

@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-0.20@f6cecf5). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             branch-0.20    #1560   +/-   ##
==============================================
  Coverage               ?   60.08%           
==============================================
  Files                  ?       73           
  Lines                  ?     3214           
  Branches               ?        0           
==============================================
  Hits                   ?     1931           
  Misses                 ?     1283           
  Partials               ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6cecf5...62554fd. Read the comment docs.

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 1c7142e into rapidsai:branch-0.20 Apr 29, 2021
@seunghwak seunghwak deleted the bug_correctness_check branch June 24, 2021 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants