Miscellaneous bug fixes #1561
Merged
Miscellaneous bug fixes #1561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seunghwak
added
3 - Ready for Review
bug
Codecov Report
@@ Coverage Diff @@
## branch-0.20 #1561 +/- ##
==============================================
Coverage ? 60.26%
==============================================
Files ? 73
Lines ? 3214
Branches ? 0
==============================================
Hits ? 1937
Misses ? 1277
Partials ? 0 Continue to review full report at Codecov.
|
| @@ -71,7 +71,7 @@ bool compare_renumbered_vectors(raft::handle_t const &handle, | |||
| v1.end(), | |||
| vertex_t{0}); | |||
|
|
|||
| rmm::device_uvector<size_t> map(max, size_t{0}); | |||
| rmm::device_uvector<size_t> map(max, cudaStream_t{nullptr}); | |||
There was a problem hiding this comment.
Should we just use handle.get_stream() here?
ChuckHastings
approved these changes
Apr 27, 2021
aschaffer
approved these changes
Apr 28, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Miscellaneous bug fixes: a compile error with CUDA 11.2 and a typo.