Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added uninstall target which uninstalls libcugraph and cugraph from a prior build/install step #1601

Merged
merged 2 commits into from
May 13, 2021

Conversation

rlratzel
Copy link
Contributor

@rlratzel rlratzel commented May 13, 2021

Added uninstall target which uninstalls libcugraph and cugraph from a prior build/install step. Also extended the clean target to remove inplace artifacts (mainly cython-generated cpp files and inplace .so python extensions built from cython).

NOTE: since targets can be combined on the same command, a user can get the "scrub" behavior by running:

./build.sh uninstall clean

@rlratzel rlratzel added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 13, 2021
@rlratzel rlratzel self-assigned this May 13, 2021
@dantegd
Copy link
Member

dantegd commented May 13, 2021

@rlratzel FYI: we do this cleaning as part of CI at least since 0.14 https://github.com/rapidsai/cuml/blob/branch-0.20/python/setup.py#L70 and it hasn't affected anything, I would recommend making this behavior just part of the clean target (just my 2 cents)

@rlratzel
Copy link
Contributor Author

@rlratzel FYI: we do this cleaning as part of CI at least since 0.14 https://github.com/rapidsai/cuml/blob/branch-0.20/python/setup.py#L70 and it hasn't affected anything, I would recommend making this behavior just part of the clean target (just my 2 cents)

Thank you @dantegd - I'll just make scrub the default clean behavior then since that simplifies things.

@rlratzel rlratzel changed the title Added scrub target which does clean plus removes inplace artifacts and uninstalls Added uninstall target which uninstalls libcugraph and cugraph from a prior build/install step May 13, 2021
@rlratzel
Copy link
Contributor Author

rlratzel commented May 13, 2021

@dantegd I decided I didn't feel comfortable uninstalling during a clean, so I made the uninstall steps a separate target but added the more thorough cleaning (inplace artifacts) part of the default clean like cuML.

Copy link
Collaborator

@ChuckHastings ChuckHastings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like it would have addressed the docker issue that @jnke2016 had today. I like the idea.

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2021

Codecov Report

Merging #1601 (572f6c5) into branch-0.20 (250f2c8) will decrease coverage by 1.13%.
The diff coverage is 62.80%.

❗ Current head 572f6c5 differs from pull request most recent head d29caa4. Consider uploading reports for the commit d29caa4 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.20    #1601      +/-   ##
===============================================
- Coverage        61.04%   59.90%   -1.14%     
===============================================
  Files               73       79       +6     
  Lines             3219     3482     +263     
===============================================
+ Hits              1965     2086     +121     
- Misses            1254     1396     +142     
Impacted Files Coverage Δ
python/cugraph/__init__.py 100.00% <ø> (ø)
python/cugraph/components/connectivity.py 95.65% <ø> (ø)
python/cugraph/dask/centrality/katz_centrality.py 29.16% <ø> (ø)
python/cugraph/dask/link_analysis/pagerank.py 21.87% <0.00%> (ø)
python/cugraph/dask/traversal/bfs.py 25.00% <0.00%> (-2.59%) ⬇️
python/cugraph/traversal/ms_bfs.py 11.11% <ø> (ø)
...ure/graph_implementation/simpleDistributedGraph.py 22.72% <22.72%> (ø)
python/cugraph/generators/rmat.py 34.44% <34.44%> (ø)
python/cugraph/linear_assignment/lap.py 71.42% <50.00%> (-10.39%) ⬇️
python/cugraph/structure/number_map.py 66.79% <57.14%> (+2.97%) ⬆️
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4905a35...d29caa4. Read the comment docs.

@BradReesWork BradReesWork added this to the 21.06 milestone May 13, 2021
@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 9c42957 into rapidsai:branch-0.20 May 13, 2021
@rlratzel rlratzel deleted the branch-0.20-scrub branch June 17, 2022 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants