-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added uninstall
target which uninstalls libcugraph and cugraph from a prior build/install step
#1601
Conversation
@rlratzel FYI: we do this cleaning as part of CI at least since 0.14 https://github.com/rapidsai/cuml/blob/branch-0.20/python/setup.py#L70 and it hasn't affected anything, I would recommend making this behavior just part of the clean target (just my 2 cents) |
Thank you @dantegd - I'll just make |
… "scrub" behavior the default for clean.
scrub
target which does clean plus removes inplace artifacts and uninstallsuninstall
target which uninstalls libcugraph and cugraph from a prior build/install step
@dantegd I decided I didn't feel comfortable uninstalling during a clean, so I made the uninstall steps a separate target but added the more thorough cleaning (inplace artifacts) part of the default clean like cuML. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels like it would have addressed the docker issue that @jnke2016 had today. I like the idea.
Codecov Report
@@ Coverage Diff @@
## branch-0.20 #1601 +/- ##
===============================================
- Coverage 61.04% 59.90% -1.14%
===============================================
Files 73 79 +6
Lines 3219 3482 +263
===============================================
+ Hits 1965 2086 +121
- Misses 1254 1396 +142
Continue to review full report at Codecov.
|
@gpucibot merge |
Added
uninstall
target which uninstalls libcugraph and cugraph from a prior build/install step. Also extended theclean
target to remove inplace artifacts (mainly cython-generated cpp files and inplace.so
python extensions built from cython).NOTE: since targets can be combined on the same command, a user can get the "scrub" behavior by running: