Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fea speedup compile #1702

Merged
merged 5 commits into from
Jul 22, 2021
Merged

Fea speedup compile #1702

merged 5 commits into from
Jul 22, 2021

Conversation

ChuckHastings
Copy link
Collaborator

@ChuckHastings ChuckHastings commented Jul 9, 2021 •
edited
Loading

Some changes to speed up compilation of cugraph. With 8 CPUs, this speeds up the overall compile time on my workstation from 13 minutes to about 9 minutes. Should speed up C++ compilation in CI by about 10 minutes total.

@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@aba3445). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 605c525 differs from pull request most recent head 0a650df. Consider uploading reports for the commit 0a650df to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #1702   +/-   ##
===============================================
  Coverage                ?   59.34%           
===============================================
  Files                   ?       80           
  Lines                   ?     3559           
  Branches                ?        0           
===============================================
  Hits                    ?     2112           
  Misses                  ?     1447           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aba3445...0a650df. Read the comment docs.

@BradReesWork BradReesWork added this to the 21.08 milestone Jul 12, 2021
@BradReesWork BradReesWork added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change 2 - In Progress labels Jul 12, 2021
@ChuckHastings ChuckHastings marked this pull request as ready for review July 19, 2021 18:22
@ChuckHastings ChuckHastings requested review from a team as code owners July 19, 2021 18:22
@ChuckHastings
Copy link
Collaborator Author

rerun tests

kaatish
kaatish reviewed Jul 22, 2021
View reviewed changes
cpp/src/detail/shuffle_wrappers.cu
d_rx_edgelist_weights),
std::ignore) =
cugraph::experimental::groupby_gpuid_and_shuffle_values(
comm, // handle.get_comms(),
Copy link
Collaborator

@kaatish kaatish Jul 22, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments left in this file are intentional? Or are you explaining that the comms object is not a row/col subcommunicator?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll clean that up in a separate PR (since this has already merged). I suspect that was something I did while debugging.

kaatish
kaatish approved these changes Jul 22, 2021
View reviewed changes
Copy link
Collaborator

@kaatish kaatish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a single clarification. Otherwise looks good.

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 49aaff6 into rapidsai:branch-21.08 Jul 22, 2021
@ChuckHastings ChuckHastings deleted the fea_speedup_compile branch July 29, 2021 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschaffer aschaffer aschaffer approved these changes

@BradReesWork BradReesWork BradReesWork approved these changes

@kaatish kaatish kaatish approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
21.08
Development

Successfully merging this pull request may close these issues.
5 participants
@ChuckHastings @codecov-commenter @BradReesWork @kaatish @aschaffer