K-core implementation for undirected graphs #1933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t can overflow if k_core_degree_type is INOUT as the maximum possible core number is (num_vertices - 1) * 2
seunghwak
added
feature request
seunghwak
changed the title
…ers to k_last for the vertices that belong to k_last+1-core as this information is useful in triangle counting so no need to throw away useful information
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #1933 +/- ##
===============================================
Coverage ? 70.35%
===============================================
Files ? 143
Lines ? 8903
Branches ? 0
===============================================
Hits ? 6264
Misses ? 2639
Partials ? 0 Continue to review full report at Codecov.
|
ChuckHastings
approved these changes
Nov 11, 2021
cpp/src/cores/core_number_impl.cuh
Outdated
| if (graph_view.is_multigraph()) { | ||
| CUGRAPH_FAIL("unimplemented."); // check for multi-edges | ||
| } | ||
| CUGRAPH_FAIL("unimplemented."); // check for self-loops |
There was a problem hiding this comment.
Do we want to add the calls just implemented in #1939 ?
kaatish
approved these changes
Nov 12, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1909.
This PR aims to implement K-core only for undirected graphs.