Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes BUG 2275 #2279

Merged
merged 7 commits into from
May 24, 2022
Merged

fixes BUG 2275 #2279

merged 7 commits into from
May 24, 2022

Conversation

BradReesWork
Copy link
Member

Fixes the bug where "to_pandas_edgelist" ignores output column names

@BradReesWork BradReesWork requested a review from a team as a code owner May 17, 2022 13:43
@BradReesWork BradReesWork added this to the 22.06 milestone May 17, 2022
@BradReesWork BradReesWork added bug Something isn't working 3 - Ready for Review non-breaking Non-breaking change labels May 17, 2022
@BradReesWork BradReesWork linked an issue May 17, 2022 that may be closed by this pull request
@BradReesWork
Copy link
Member Author

rerun tests

@codecov-commenter
Copy link

codecov-commenter commented May 18, 2022

Codecov Report

Merging #2279 (1bf0af0) into branch-22.06 (38be932) will decrease coverage by 7.03%.
The diff coverage is n/a.

❗ Current head 1bf0af0 differs from pull request most recent head 6f65185. Consider uploading reports for the commit 6f65185 to get more accurate results

@@               Coverage Diff                @@
##           branch-22.06    #2279      +/-   ##
================================================
- Coverage         70.82%   63.78%   -7.04%     
================================================
  Files               170      100      -70     
  Lines             11036     4498    -6538     
================================================
- Hits               7816     2869    -4947     
+ Misses             3220     1629    -1591     
Impacted Files Coverage Δ
python/cugraph/cugraph/__init__.py 100.00% <ø> (ø)
python/cugraph/cugraph/centrality/__init__.py 100.00% <ø> (ø)
...graph/cugraph/centrality/betweenness_centrality.py 89.65% <ø> (ø)
...on/cugraph/cugraph/centrality/degree_centrality.py 81.81% <ø> (ø)
...thon/cugraph/cugraph/centrality/katz_centrality.py 88.23% <ø> (-1.24%) ⬇️
python/cugraph/cugraph/community/egonet.py 97.36% <ø> (ø)
...ython/cugraph/cugraph/community/ktruss_subgraph.py 88.23% <ø> (+2.94%) ⬆️
python/cugraph/cugraph/community/leiden.py 100.00% <ø> (+7.69%) ⬆️
python/cugraph/cugraph/community/louvain.py 100.00% <ø> (+7.69%) ⬆️
python/cugraph/cugraph/community/triangle_count.py 100.00% <ø> (+11.11%) ⬆️
... and 130 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1489712...6f65185. Read the comment docs.

@BradReesWork BradReesWork requested a review from betochimas May 19, 2022 17:45
Copy link
Contributor

@jnke2016 jnke2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@betochimas
Copy link
Contributor

Observing from the current CI failures in test_convert_matrix.py and test_multigraph.py, some columns need to be renamed after this API change. In multiple tests from test_convert_matrix, the columns of res_pdf could be renamed:
res_pdf = res_pdf.rename(columns={"source": "src", "destination": "dst"})

Copy link
Contributor

@jnke2016 jnke2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this small change has some ramification on some tests

@BradReesWork
Copy link
Member Author

the test in test_convert_matrix assume that the returned column names are "src", "dst", and "weight", so the updated function will help ensure that. and I fixed all the calls to DiGraph

@BradReesWork
Copy link
Member Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 305392d into rapidsai:branch-22.06 May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] to_pandas_edgelist ignores parameters source, destination
5 participants