Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate SG and MG BFS to pylibcugraph #2284

Merged
merged 23 commits into from
May 23, 2022
Merged

Migrate SG and MG BFS to pylibcugraph #2284

merged 23 commits into from
May 23, 2022

Conversation

alexbarghi-nv
Copy link
Member

Closes #2270

alexbarghi-nv and others added 12 commits May 16, 2022 09:07
@alexbarghi-nv
Merge pull request #1 from rapidsai/branch-22.06
fb2d21c 
pull latest updates
@alexbarghi-nv
Merge branch 'rapidsai:branch-22.06' into branch-22.06
cfdb13b
@alexbarghi-nv
sg and mg bfs plc migration work
29f6a8b
@alexbarghi-nv
remove cufile
3c00af1
@alexbarghi-nv
Merge remote-tracking branch 'origin/branch-22.06' into branch-22.06-…
47388f8 
…pylibcugraph-bfs
@alexbarghi-nv
Merge pull request #2 from rapidsai/branch-22.06
a151b63 
Add MG Hits and MG Neighborhood_sampling to benchmarks (rapidsai#2254)
@alexbarghi-nv
Merge remote-tracking branch 'origin/branch-22.06' into branch-22.06-…
764782a 
…pylibcugraph-bfs
@alexbarghi-nv
add bfs mg c api test, small fixes
42c9e16
@alexbarghi-nv
remove testing files
af0eb2a
@alexbarghi-nv
update mg bfs test
97b76e7
@ChuckHastings
Add Alex B's mg_bfs_test, add mg_sssp_test, fix support for MG in bfs…
3b9914f 
… and sssp
@alexbarghi-nv
Merge pull request #3 from ChuckHastings/fix_add_shuffle_to_capi_algo…
0dbe0b5 
…rithms

Fix add shuffle to capi algorithms
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@alexbarghi-nv alexbarghi-nv marked this pull request as ready for review May 20, 2022 15:08
@alexbarghi-nv alexbarghi-nv requested review from a team as code owners May 20, 2022 15:08
@rlratzel rlratzel added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python labels May 20, 2022
rlratzel
rlratzel requested changes May 20, 2022
View reviewed changes
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple minor issues.

cpp/tests/CMakeLists.txt Outdated Show resolved Hide resolved
python/pylibcugraph/pylibcugraph/experimental/__init__.py Outdated Show resolved Hide resolved
rlratzel
rlratzel approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but python/cufile.log was accidentally added so that should be removed, but that need not hold up approval.

@alexbarghi-nv
Copy link
Member Author

LGTM, but python/cufile.log was accidentally added so that should be removed, but that need not hold up approval.

fixed.

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2022 •
edited
Loading

Codecov Report

Merging #2284 (c5fc19a) into branch-22.06 (aece453) will decrease coverage by 0.06%.
The diff coverage is 28.81%.

@@               Coverage Diff                @@
##           branch-22.06    #2284      +/-   ##
================================================
- Coverage         63.80%   63.73%   -0.07%     
================================================
  Files               100      100              
  Lines              4481     4495      +14     
================================================
+ Hits               2859     2865       +6     
- Misses             1622     1630       +8
Impacted Files Coverage Δ
python/cugraph/cugraph/dask/traversal/bfs.py 15.38% <10.63%> (+0.63%) ⬆️
python/cugraph/cugraph/traversal/bfs.py 81.25% <100.00%> (+2.37%) ⬆️
python/pylibcugraph/pylibcugraph/__init__.py 100.00% <100.00%> (ø)
...n/pylibcugraph/pylibcugraph/utilities/api_tools.py 88.05% <0.00%> (-7.47%) ⬇️
python/cugraph/cugraph/sampling/node2vec.py 81.81% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aece453...c5fc19a. Read the comment docs.

@rlratzel
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 5f72b19 into rapidsai:branch-22.06 May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betochimas betochimas betochimas approved these changes

@rlratzel rlratzel rlratzel approved these changes

Assignees

@alexbarghi-nv alexbarghi-nv

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add pylibcugraph.bfs, update cugraph.bfs to call pylibcugraph
5 participants
@alexbarghi-nv @codecov-commenter @rlratzel @betochimas @ChuckHastings