Update unit tests to leverage the datasets API #2733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BradReesWork
added
improvement
rlratzel
approved these changes
Oct 3, 2022
Comment on lines
175
to
177
| G = cugraph.Graph(directed=True) | ||
| # FIXME: Find a cleaner way to return a directed graph | ||
| G = graph_file.get_graph(create_using=G) |
There was a problem hiding this comment.
slightly cleaner:
Suggested change
| G = cugraph.Graph(directed=True) | |
| # FIXME: Find a cleaner way to return a directed graph | |
| G = graph_file.get_graph(create_using=G) | |
| G = graph_file.get_graph(create_using=cugraph.Graph(directed=True)) |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-22.10 #2733 +/- ##
===============================================
Coverage ? 59.72%
===============================================
Files ? 111
Lines ? 6448
Branches ? 0
===============================================
Hits ? 3851
Misses ? 2597
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
rerun tests |
…0_fea-update-unit-tests
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
BradReesWork
approved these changes
Oct 5, 2022
|
@gpucibot merge |
|
rerun tests |
1 similar comment
|
rerun tests |
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the unit tests to leverage the datasets API by updating the utils functions. This greatly simplifies the graph creation from an edgelist with a single call
get_edgelist()by abstracting the following calls:cudf.read_csv,from_cudf_edgelistcloses #2408