added a passthrough for storing transposed #2799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BradReesWork
added
improvement
acostadon
approved these changes
Oct 14, 2022
There was a problem hiding this comment.
the store_transposed warning messages relate to issue #2806
The warning message suggests that transposing the graph is optional for efficiency but in at least my experience it prevented the algorithm from running.
The changes look good to me just wondering if the warnings match with the behavior.
rlratzel
approved these changes
Oct 14, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both PageRank and Katz have better performance is the graph is stored transposed. However whne the input is a NetworkX graph, there was no option to specify to store transposed. Added a argument to nx_factory to specify the store_transposed flag.
Updated Pagerank and Katz to specify the transpose when converting from Nx
Closes #2792