Fix concat with different index dtypes in SG PropertyGraph #2804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbarghi-nv
added
improvement
|
Sorry missed this, just raised a PR to fix the same. Lets merge this in please. |
VibhuJawa
suggested changes
Oct 18, 2022
There was a problem hiding this comment.
Looks good to me. Can we just add a test like this:
def test_get_num_vertices():
from cugraph.experimental import PropertyGraph
pg = PropertyGraph()
node_df = cudf.DataFrame()
node_df["node_id"] = cudf.Series([0, 1, 2]).astype("int32")
pg.add_vertex_data(node_df, "node_id", type_name="_N")
edge_df = cudf.DataFrame()
edge_df["src"] = cudf.Series([0, 1, 2]).astype("int32")
edge_df["dst"] = cudf.Series([0, 1, 2]).astype("int32")
pg.add_edge_data(edge_df, ["src", "dst"], type_name="_E")
assert pg.get_num_vertices() == 3
This was referenced Oct 18, 2022
|
Thanks for the test @VibhuJawa! Added. Sorry you missed this PR and did duplicate work. I confirmed your test breaks w/o this PR and passes with this PR. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #2804 +/- ##
===============================================
Coverage ? 60.48%
===============================================
Files ? 111
Lines ? 6526
Branches ? 0
===============================================
Hits ? 3947
Misses ? 2579
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
rlratzel
reviewed
Oct 19, 2022
rlratzel
approved these changes
Oct 19, 2022
|
rerun tests reason: timeout as described in #2810 - rerunning for now. |
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Oct 27, 2022
Resolves rapidsai/graph_dl#76 Merge after #2804 This PR defines a remote interface for `Graph` and `PropertyGraph` so they can be easily substituted in a client application that does not use `cugraph` directly. For `PropertyGraph`, this PR also implements most of the functionality of a native `PropertyGraph`. Note: this PR does not include the upcoming "dispatch" updates for running cugraph algorithms or subgraph extraction, which are covered under rapidsai/graph_dl#80 Authors: - Alex Barghi (https://github.com/alexbarghi-nv) - Erik Welch (https://github.com/eriknw) Approvers: - Joseph Nke (https://github.com/jnke2016) - Rick Ratzel (https://github.com/rlratzel) URL: #2821
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alexbarghi-nv want to give this a try? I previously made these changes to MG (was there an issue for it?), but not SG.