Updte transform_reduce_e_by_src|dst_key to take a custom reduction op #2813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@naimnv FYI, I assume this is necessary for Leiden implementation. |
seunghwak
added
feature request
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #2813 +/- ##
===============================================
Coverage ? 60.44%
===============================================
Files ? 111
Lines ? 6515
Branches ? 0
===============================================
Hits ? 3938
Misses ? 2577
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ChuckHastings
approved these changes
Oct 17, 2022
jnke2016
approved these changes
Oct 18, 2022
naimnv
approved these changes
Oct 18, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
transform_reduce_e_by_src|dst_key is updated to take an additional input parameter (ReduceOp reduce_op).
Marked as non-breaking as primitives are currenlty not part of the public API (located in src/prims).