Fix bug in how is_symmetric is set when transposing storage #2898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChuckHastings
added
3 - Ready for Review
bug
jnke2016
approved these changes
Nov 9, 2022
seunghwak
reviewed
Nov 9, 2022
| auto is_symmetric = graph.is_symmetric(); | ||
|
|
||
| // FIXME: if is_symmetric is true we can do this more efficiently, | ||
| // since the graph contents should be exactly the same |
There was a problem hiding this comment.
We may handle this inside the C++ function. We can check the flag and if symmetric, it might be possible to just move all the graph contents.
There was a problem hiding this comment.
And why aren't you directly calling transpose_graph_storage? (https://github.com/rapidsai/cugraph/blob/branch-22.12/cpp/src/structure/transpose_graph_storage_impl.cuh#L168)
There was a problem hiding this comment.
I'm confused by these comments. This is the C++ function.
There was a problem hiding this comment.
Oops :-( Sorry... I thought this is the C API function...
seunghwak
approved these changes
Nov 9, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
tranpose_storagefunction was incorrectly setting graph properties.