Bulk Sampling #3148
Closed
Bulk Sampling #3148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2-initial_service_benchmarks
…art so it fails faster, including the stdout/stderr output in the exception raised or to console depending on how it exited.
…chmarks for different libraries.
…ir to pytest-based to avoid name conflict.
… can be more easily shared, bug fix in benchmark extension testing util.
…params, removed funcs unused in each file.
…arkers to pytest.ini, added pythonpath and test paths to pytest.ini, gave benchmark files unique names so pytest can collect them across different bench dirs.
…ception handler for loading extensions, run server from a temp dir to avoid collisions with 'cugraph' namespace package in benchmarks dir.
…2-initial_benchmark_reorg
…, added markers for each batch size.
alexbarghi-nv
added
non-breaking
VibhuJawa
suggested changes
Jan 24, 2023
VibhuJawa
previously approved these changes
Jan 26, 2023
python/cugraph/cugraph/dask/sampling/uniform_neighbor_sample.py
Outdated
Show resolved
Hide resolved
VibhuJawa
reviewed
Jan 26, 2023
| @@ -250,17 +273,21 @@ def uniform_neighbor_sample( | |||
| weight_t=weight_t, | |||
| with_edge_properties=with_edge_properties, | |||
| # FIXME accept and properly transmute a numpy/cupy random state. | |||
| random_state=hash(random_state, i), | |||
There was a problem hiding this comment.
Just a comment that catching bugs like this is why we need to get dask even on SG to run in CI ASAP. CC: @rlratzel
Co-authored-by: Vibhu Jawa <[email protected]>
BradReesWork
dismissed stale reviews from VibhuJawa and ChuckHastings
The base branch was changed.
|
pre-empted by #3170 |
rapids-bot bot
pushed a commit
that referenced
this pull request
Jan 31, 2023
This PR depends upon ~#3148 (#3170) This PR closes #3154 - [x] Works on SG Homogenous Graph (OBGN-Products) - [x] Works on SG Heterogenous Graphs (OBGN-Mag) - [x] Works on MG Homogenous Graphs (OBGN-Products, OBGN-PAPERS100M (1 Billion edge graph)) - [x] Works on MG Heterogenous Graphs (OBGN-Mag) Tests to add: - [x] Tests on SG Homogenous Graphs - [x] Tests on SG Heterogenous Graphs - [x] Tests on MG Homogenous Graphs - [x] Tests on MG Heterogenous Graphs Maybe Todo: <s>- [ ] Test Multi-trainer examples and verification </s> (Will do a follow up) Authors: - Vibhu Jawa (https://github.com/VibhuJawa) - Rick Ratzel (https://github.com/rlratzel) - Alex Barghi (https://github.com/alexbarghi-nv) - Chuck Hastings (https://github.com/ChuckHastings) Approvers: - Alex Barghi (https://github.com/alexbarghi-nv) - Rick Ratzel (https://github.com/rlratzel) URL: #3181
rapids-bot bot
pushed a commit
that referenced
this pull request
Jan 31, 2023
Closes #3152 Depends on #3148 and #3159 This PR does support multiple trainers, even though there is no example for it. Authors: - Alex Barghi (https://github.com/alexbarghi-nv) - Chuck Hastings (https://github.com/ChuckHastings) - Vibhu Jawa (https://github.com/VibhuJawa) Approvers: - Vibhu Jawa (https://github.com/VibhuJawa) - Rick Ratzel (https://github.com/rlratzel) URL: #3170
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3040
Merge after #3101 and #3082
Also resolves two major bugs in MG sampling, one that results in an error when not passing a seed, and another that causes the sampling call to hang on MG.