Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop extraneous columns that were appearing in MGPropertyGraph #3191

Merged
merged 2 commits into from
Jan 30, 2023

Conversation

eriknw
Copy link
Contributor

@eriknw eriknw commented Jan 26, 2023

Fixes #3185

@eriknw eriknw requested a review from a team as a code owner January 26, 2023 21:15
Copy link
Member

@alexbarghi-nv alexbarghi-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alexbarghi-nv alexbarghi-nv added Fix non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Jan 26, 2023
@BradReesWork BradReesWork added this to the 23.02 milestone Jan 30, 2023
@codecov-commenter
Copy link

Codecov Report

Base: 55.30% // Head: 55.21% // Decreases project coverage by -0.09% ⚠️

Coverage data is based on head (97fb536) compared to base (068629e).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-23.02    #3191      +/-   ##
================================================
- Coverage         55.30%   55.21%   -0.09%     
================================================
  Files               148      148              
  Lines              9573     9564       -9     
================================================
- Hits               5294     5281      -13     
- Misses             4279     4283       +4     
Impacted Files Coverage Δ
...ugraph/cugraph/dask/structure/mg_property_graph.py 11.90% <0.00%> (-0.02%) ⬇️
...ython/cugraph/cugraph/community/ktruss_subgraph.py 85.29% <0.00%> (-5.89%) ⬇️
python/cugraph/cugraph/dask/common/input_utils.py 21.95% <0.00%> (-1.86%) ⬇️
...cugraph-pyg/cugraph_pyg/sampler/cugraph_sampler.py 80.00% <0.00%> (-0.33%) ⬇️
...raph/structure/graph_implementation/simpleGraph.py 78.12% <0.00%> (-0.25%) ⬇️
python/cugraph/cugraph/structure/property_graph.py 93.95% <0.00%> (-0.06%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BradReesWork
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 6775bf7 into rapidsai:branch-23.02 Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MGPropertyGraph methods add unexpected columns
4 participants