Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Fix libraft-distance version in 23.04 #3241

Merged
merged 7 commits into from
Feb 7, 2023
Merged

[REVIEW] Fix libraft-distance version in 23.04 #3241

merged 7 commits into from
Feb 7, 2023

Conversation

galipremsagar
Copy link
Contributor

This PR fixes libraft-distnace version in 23.04 and adds the entry to update-version.sh script.

@galipremsagar galipremsagar requested a review from a team as a code owner February 6, 2023 19:46
@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review non-breaking Non-breaking change labels Feb 6, 2023
@galipremsagar galipremsagar mentioned this pull request Feb 6, 2023
Closed
@galipremsagar galipremsagar changed the base branch from branch-23.04 to branch-23.02 February 6, 2023 22:16
@galipremsagar galipremsagar requested review from a team as code owners February 6, 2023 22:16
@galipremsagar galipremsagar changed the base branch from branch-23.02 to branch-23.04 February 6, 2023 22:16
galipremsagar
galipremsagar commented Feb 6, 2023
View reviewed changes
.github/workflows/build.yaml Outdated Show resolved Hide resolved
.github/workflows/build.yaml Outdated Show resolved Hide resolved
.github/workflows/build.yaml Outdated Show resolved Hide resolved
.github/workflows/build.yaml Outdated Show resolved Hide resolved
.github/workflows/build.yaml Outdated Show resolved Hide resolved
.github/workflows/pr.yaml Outdated Show resolved Hide resolved
.github/workflows/test.yaml Outdated Show resolved Hide resolved
.github/workflows/test.yaml Outdated Show resolved Hide resolved
.github/workflows/test.yaml Outdated Show resolved Hide resolved
.github/workflows/test.yaml Outdated Show resolved Hide resolved
rlratzel
rlratzel approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rlratzel
Copy link
Contributor

rlratzel commented Feb 6, 2023

/merge

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-23.04@a892ddf). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files 
@@               Coverage Diff               @@
##             branch-23.04    #3241   +/-   ##
===============================================
  Coverage                ?   56.26%           
===============================================
  Files                   ?      153           
  Lines                   ?     9658           
  Branches                ?        0           
===============================================
  Hits                    ?     5434           
  Misses                  ?     4224           
  Partials                ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rapids-bot rapids-bot bot merged commit b0ee475 into rapidsai:branch-23.04 Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChuckHastings ChuckHastings ChuckHastings approved these changes

@raydouglass raydouglass raydouglass approved these changes

@rlratzel rlratzel rlratzel approved these changes

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@galipremsagar @rlratzel @codecov-commenter @raydouglass @ChuckHastings