Disables memory usage assertions #3641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlratzel
added
improvement
BradReesWork
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables the assertions intended to check if memory is being allocated and free'd as expected. Recent failures occurring seemingly infrequently have caused suspicion as to whether these are accurately ensuring if memory is free'd or not. Plus, if the tests change to use memory pools, or pytest-xdist which result in GPU sharing, these assertions will also fail.
Instead, this PR adds a variable which can be easily set to enable or disable the assertions. This will make it convenient for testing for memory leaks locally when the developer knows the environment is appropriate for these assertions. We will likely add memory leak checking back in on a case-by-case basis, possibly using different tools, in a future PR.