Fix sampling call parameters if compiled with -DNO_CUGRAPH_OPS #3729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChuckHastings
added
bug
seunghwak
approved these changes
Jul 21, 2023
| std::optional<std::tuple<raft::device_span<int32_t const>, raft::device_span<int32_t const>>> | ||
| label_to_output_comm_rank_mapping{std::nullopt}; | ||
|
|
||
| #ifdef NO_CUGRAPH_OPS | ||
| EXPECT_THROW( | ||
| cugraph::uniform_neighbor_sample( |
There was a problem hiding this comment.
Just FYI, this is one way to fix this, another is to call this function with explicit template types.
i.e. cugraph::uniform_neighbor_sample<explicit template types...>(...);
This might be less verbose in some cases.
bdice
approved these changes
Jul 21, 2023
There was a problem hiding this comment.
This passed local builds for me. Thanks for the fix @ChuckHastings!
seunghwak
approved these changes
Jul 21, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated sampling call in the
#ifdef NO_CUGRAPH_OPSbranch of the SG unit test. The MG unit test was correctly updated previously.Fixes #3726