Enable parallel mode #3875
Merged
Enable parallel mode #3875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BradReesWork
added
improvement
naimnv
reviewed
Sep 26, 2023
naimnv
reviewed
Sep 26, 2023
naimnv
approved these changes
Oct 31, 2023
rlratzel
requested changes
Nov 10, 2023
Comment on lines
+50
to
+71
| fixture_params = gen_fixture_params_product( | ||
| (datasets, "graph_file"), | ||
| ([True, False], "distributed"), | ||
| ([True, False], "use_weights"), | ||
| ([True, False], "use_edge_ids"), | ||
| ([True, False], "use_edge_type_ids"), | ||
| ) | ||
|
|
||
|
|
||
| @pytest.fixture(scope="module", params=fixture_params) | ||
| def input_combo(request): | ||
| """ | ||
| Simply return the current combination of params as a dictionary for use in | ||
| tests or other parameterized fixtures. | ||
| """ | ||
| return dict( | ||
| zip( | ||
| ( | ||
| "graph_file", | ||
| "use_weights", | ||
| "use_edge_ids", | ||
| "use_edge_type_ids", | ||
| "distributed", | ||
| ), | ||
| request.param, | ||
| ) | ||
| ) |
There was a problem hiding this comment.
This pattern isn't as useful here since there's only one test. It might be better for future maintainers if the test in this file just used regular pytest parameters.
jnke2016
force-pushed
the
branch-23.10_batch-mode
branch
from
48e3f00 to
58014b9
Compare
BradReesWork
approved these changes
Nov 17, 2023
jnke2016
force-pushed
the
branch-23.10_batch-mode
branch
from
0146339 to
3f09595
Compare
rlratzel
requested changes
Nov 20, 2023
python/cugraph/cugraph/tests/internals/test_replicate_edgelist_mg.py
Outdated
Show resolved
Hide resolved
rlratzel
approved these changes
Nov 20, 2023
AyodeAwe
approved these changes
Nov 20, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables parallel mode
Closes https://github.com/rapidsai/graph_dl/issues/328