Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup Consistent Nightly Versions for Pip and Conda #3933

Merged
merged 29 commits into from
Nov 1, 2023
Merged

Setup Consistent Nightly Versions for Pip and Conda #3933

merged 29 commits into from
Nov 1, 2023

Conversation

divyegala
Copy link
Member

@divyegala divyegala commented Oct 12, 2023 •
edited
Loading

@divyegala divyegala requested review from a team as code owners October 12, 2023 23:52
@vyasr vyasr added improvement Improvement / enhancement to an existing function DO NOT MERGE Hold off on merging; see PR for details non-breaking Non-breaking change labels Oct 13, 2023
@divyegala divyegala requested a review from a team as a code owner October 18, 2023 23:53
ajschmidt8
ajschmidt8 reviewed Oct 27, 2023
View reviewed changes
ci/build_python.sh Outdated Show resolved Hide resolved
rlratzel
rlratzel requested changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating us. Since this change adds new infrastructure that we'll want to be able to maintain, I requested a few comments be added in places. Looks good otherwise.

ci/release/update-version.sh Show resolved Hide resolved
python/cugraph-dgl/cugraph_dgl/_version.py Show resolved Hide resolved
rlratzel
rlratzel approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, I think that is very helpful to future maintainers.

@rlratzel rlratzel removed the DO NOT MERGE Hold off on merging; see PR for details label Nov 1, 2023
@vyasr
Copy link
Contributor

vyasr commented Nov 1, 2023

/merge

@rapids-bot rapids-bot bot merged commit f4bcdc2 into rapidsai:branch-23.12 Nov 1, 2023
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr left review comments

@ChuckHastings ChuckHastings ChuckHastings approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@rlratzel rlratzel rlratzel approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@divyegala @vyasr @rlratzel @ajschmidt8 @ChuckHastings