Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip certain cugraph-pyg tests when torch-sparse is not available #3970

Merged
merged 4 commits into from
Nov 3, 2023

Conversation

tingyu66
Copy link
Member

@tingyu66 tingyu66 commented Nov 1, 2023

A follow-up PR to fix the test failure again on rockylinux (see log).

import_optional only catches ModuleNotFoundError, however, it threw an OSError on rockylinux. Let's just catch all exceptions during imports in this case.

Closes https://github.com/rapidsai/graph_dl/issues/373

@tingyu66 tingyu66 requested a review from a team as a code owner November 1, 2023 20:17
@tingyu66 tingyu66 self-assigned this Nov 1, 2023
@tingyu66 tingyu66 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 1, 2023
@BradReesWork
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 2bdb735 into rapidsai:branch-23.12 Nov 3, 2023
71 checks passed
@tingyu66 tingyu66 deleted the skip-tests branch November 3, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants