Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nx-cugraph: add SSSP (unweighted) #3976

Merged
merged 5 commits into from
Nov 20, 2023
Merged

Conversation

eriknw
Copy link
Contributor

@eriknw eriknw commented Nov 3, 2023

There are many more traversal algorithms to implement, but these get us started!

@eriknw eriknw requested a review from a team as a code owner November 3, 2023 20:55
@eriknw
Copy link
Contributor Author

eriknw commented Nov 4, 2023

The errors are interesting:

RuntimeError: non-success value returned from cugraph_bfs: CUGRAPH_UNKNOWN_ERROR std::bad_alloc: out_of_memory: CUDA error at:

We are calling plc.bfs repeatedly as part of all_pairs_shortest_path_length, but shouldn't this work still? Shouldn't memory be cleaned up? All results are turned into Python dicts and they shouldn't be on device anymore.

Heh, so it looks like single_source_shortest_path_length is a good example of a networkx algorithm that other networkx algorithms call in a loop. It's used by (at least) these:

  • all_pairs_shortest_path_length
  • closeness_centrality
  • bipartite.closeness_centrality
  • incremental_closeness_centrality
  • average_shortest_path_length

@BradReesWork BradReesWork added this to the 23.12 milestone Nov 15, 2023
@BradReesWork BradReesWork added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 20, 2023
@rlratzel
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 6e765bb into rapidsai:branch-23.12 Nov 20, 2023
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants