Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle more RAPIDS version formats in update-version.sh, refactor dependencies.yaml #4109

Merged
merged 12 commits into from
Feb 8, 2024

Conversation

jameslamb
Copy link
Member

Description

Contributes to rapidsai/build-planning#13.

Updates update-version.sh to correctly handle RAPIDS dependencies like cudf-cu12==24.2.*.

This also pulls in some dependency refactoring originally added in #4088, which allows greater use of dependencies.yaml globs (and therefore less maintenance effort to support new CUDA versions).

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

How I tested this

The portability of this updated sed command was tested here: rapidsai/cudf#14825 (comment).

In this repo, I ran the following:

# running in docker because some of this repo's `update-version.sh` stuff doesn't work with mac's sed
docker run \
  --rm \
  -v $(pwd):/opt/scratch \
  -w /opt/scratch \
  -it rapidsai/ci-conda:cuda11.8.0-ubuntu22.04-py3.10 \
  bash

./ci/release/update-version.sh '23.12.00'
git diff

./ci/release/update-version.sh '24.04.00'
git diff

Confirmed that that first git diff changed all the things I expected, and that second one showed 0 changes.

dependencies.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with one small suggestion.

@jameslamb
Copy link
Member Author

This CI failure:

  CMake Error at /home/coder/cugraph-ops/cpp/build/release/_deps/raft-build/raft-targets.cmake:56 (set_target_properties):
    The link interface of target "raft::raft" contains:
  
      hnswlib::hnswlib
  
    but the target was not found.  Possible reasons include:
  
      * There is a typo in the target name.
      * A find_package call is missing for an IMPORTED target.
      * An ALIAS target is missing.

(build link)

Should hopefully be fixed by rapidsai/raft#2135

@jameslamb jameslamb requested a review from a team as a code owner January 31, 2024 16:43
@jameslamb
Copy link
Member Author

I just pulled latest branch-24.04 and re-ran update-version.sh. Realized there are a few more branch updates for GitHub Actions workflows that were missed: 9090fc2

@jameslamb
Copy link
Member Author

ah looks like @jakirkham noticed the same thing on #4127.

Let's get that one passing and merged first, then update this one.

@BradReesWork BradReesWork requested a review from rlratzel January 31, 2024 17:39
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I didn't verify the regexes in the sed calls work so I'm assuming that was tested.

@github-actions github-actions bot removed the python label Feb 1, 2024
@jakirkham
Copy link
Member

ah looks like @jakirkham noticed the same thing on #4127.

Let's get that one passing and merged first, then update this one.

That PR is now merged. So we should be good to update here

@BradReesWork BradReesWork modified the milestones: 24.02, 24.04 Feb 2, 2024
@jameslamb
Copy link
Member Author

Thanks @jakirkham , I've updated this to the latest branch-24.04.

@jakirkham
Copy link
Member

Thanks James! 🙏

Looks like we are seeing some test failures with CUDA 12 wheels. Not sure if they are related to this change

@bdice
Copy link
Contributor

bdice commented Feb 2, 2024

I think the Python test failures could be related to pandas 2 changes in cudf. There are lots of separate failure cases.
https://github.com/rapidsai/cugraph/actions/runs/7758006471/job/21161144430?pr=4109#step:7:4281

@vyasr
Copy link
Contributor

vyasr commented Feb 5, 2024

Python failures should be fixed when #4144 merges

@bdice
Copy link
Contributor

bdice commented Feb 7, 2024

/merge

@rapids-bot rapids-bot bot merged commit 9ad7389 into rapidsai:branch-24.04 Feb 8, 2024
110 checks passed
@jakirkham jakirkham mentioned this pull request Feb 8, 2024
@jameslamb jameslamb deleted the update-version branch February 8, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants