Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds option to rapids_cpm_find for raft to disable hnswlib feature, adds updates for pytest 8 compat, temporarily skips IO intensive test in CI #4121

Merged
merged 7 commits into from
Feb 1, 2024
Merged

Adds option to rapids_cpm_find for raft to disable hnswlib feature, adds updates for pytest 8 compat, temporarily skips IO intensive test in CI #4121

merged 7 commits into from
Feb 1, 2024

Conversation

rlratzel
Copy link
Contributor

@rlratzel rlratzel commented Jan 27, 2024 •
edited
Loading

  • Adds option to rapids_cpm_find for raft to disable hnswlib feature, which is not needed by cugraph. This resolves cmake failures such as the following: 
         CMake Error at /home/coder/cugraph/cpp/build/release/_deps/raft-build/raft-targets.cmake:56 (set_target_properties):
      The link interface of target "raft::raft" contains:

        hnswlib::hnswlib


      but the target was not found.
  • TEMPORARILY skips bulk sampling IO tests which were hanging on CI runners. These tests pass locally, so we believe this is related to IO issues on CI runners, but will investigate further in 24.04
  • Adds updates for pytest >=8
    • Adds option to pytest to append source paths to PYTHONPATH instead of prepend (the default). The prepended PYTHONPATH caused the dask LocalCUDACluster to import cugraph modules from the source tree instead of the install location, which resulted in ImportErrors. This appears to be a behavior change in pytest 8.
    • Adds an xfail for an NX test known to be incompatible with pytest>=8

@rlratzel rlratzel added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 27, 2024
@rlratzel rlratzel added this to the 24.02 milestone Jan 27, 2024
@rlratzel rlratzel requested a review from divyegala January 27, 2024 01:42
@rlratzel rlratzel self-assigned this Jan 27, 2024
@rlratzel rlratzel requested a review from a team as a code owner January 27, 2024 01:42
@rlratzel
Copy link
Contributor Author

/merge

@bdice bdice mentioned this pull request Jan 29, 2024
Merged
raydouglass pushed a commit to rapidsai/raft that referenced this pull request Jan 29, 2024
@divyegala
conditionally include hnsw source (#2135)
f876491 
This PR conditionally includes `hnsw` sources, to prevent build errors like those seen in cuGraph after #2022 was merged. See also: rapidsai/cugraph#4121, rapidsai/cugraph#4122

Authors:
   - Divye Gala (https://github.com/divyegala)

Approvers:
   - Corey J. Nolet (https://github.com/cjnolet)
   - Bradley Dice (https://github.com/bdice)
   - Robert Maynard (https://github.com/robertmaynard)
@rlratzel rlratzel requested a review from a team as a code owner January 30, 2024 20:33
@github-actions github-actions bot added the ci label Jan 30, 2024
@rlratzel rlratzel changed the title Adds option to rapids_cpm_find for raft to disable hnswlib feature Adds option to rapids_cpm_find for raft to disable hnswlib feature, adds pytest option to append to path for dask in CI, temporarily skips IO intensive test in CI Jan 31, 2024
@rlratzel rlratzel requested a review from a team as a code owner January 31, 2024 21:45
@rlratzel rlratzel changed the title Adds option to rapids_cpm_find for raft to disable hnswlib feature, adds pytest option to append to path for dask in CI, temporarily skips IO intensive test in CI Adds option to rapids_cpm_find for raft to disable hnswlib feature, adds updates for pytest 8 compat, temporarily skips IO intensive test in CI Jan 31, 2024
@BradReesWork
Copy link
Member

/merge

@BradReesWork
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit b1495ed into rapidsai:branch-24.02 Feb 1, 2024
113 of 118 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChuckHastings ChuckHastings ChuckHastings approved these changes

@divyegala divyegala divyegala approved these changes

@raydouglass raydouglass raydouglass approved these changes

@eriknw eriknw eriknw approved these changes

Assignees

@rlratzel rlratzel

Labels
ci CMake cuGraph improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
None yet
Milestone
24.02
Development

Successfully merging this pull request may close these issues.
6 participants
@rlratzel @BradReesWork @eriknw @raydouglass @divyegala @ChuckHastings