Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cugraph examples #4128

Merged
merged 104 commits into from
Mar 15, 2024
Merged

cugraph examples #4128

merged 104 commits into from
Mar 15, 2024

Conversation

naimnv
Copy link
Contributor

@naimnv naimnv commented Jan 31, 2024 •
edited by ChuckHastings
Loading

This PR adds example on how to use libcugraph to run different algorithms.

Closes #2676

Naim added 30 commits November 29, 2023 02:51
Add scaffolding for ecg implementation
1a29c04
Remove unused header files
aed75f4
first version of MNMG ecg implementation
563015a
Merge branch 'branch-24.02' of github.com:rapidsai/cugraph into ecg
64b13ab
First version of MNMG ecg implementation
013e1d7
Run ensample leiden for only one level
24fe91d
Run ensample leiden for only one level
4ee5f4b
MNMG ECG with Louvain
b2f458a
Random assignment of initial cluster ids
276f42c
Randomize initial cluster assignments
bb09206
Add rng state to Louvain
6ce0b61
Merge branch 'branch-24.02' of github.com:rapidsai/cugraph into ecg
909c710
Remove debugging code
baee0a9
Add MG Ecg tests
103a6be
Add MG ECG tests
0485a18
Add copyright
e2ab79f
Remove debug code
93800b7
Merge branch 'branch-24.02' of github.com:rapidsai/cugraph into ecg
6fa8ac7
Add missing random shuffling
bd28dc9
Fix vector size
867093c
Use device_allgatherv instead of P2P to distribute extra numbers
d0b37dc
Fix SG code branching
8d7881b
Compute final modularity based on original edge weights
c201309
Address PR comments
8fc6be0
Update doc-strings
741e715
Update doc-strings
e618aca
Merge branch 'branch-24.02' of github.com:rapidsai/cugraph into ecg_m…
ec4ec86 
…erged_with_24_02
skip calling .view() on empty graph object
ec05f3f
Address PR comments
fab6f35
Address PR comments
df7f25f
@BradReesWork BradReesWork added this to the 24.04 milestone Mar 12, 2024
acostadon
acostadon reviewed Mar 14, 2024
View reviewed changes
Copy link
Contributor

@acostadon acostadon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
My comments were just questions that might be too basic but since this is an example to demonstrate the functionality, I thought maybe the additional explanation would help.

cpp/examples/developers/vertex_and_edge_partition/vertex_and_edge_partition.cu Show resolved Hide resolved
cpp/examples/users/multi_gpu_application/mg_graph_algorithms.cpp Outdated Show resolved Hide resolved
cpp/examples/users/multi_gpu_application/mg_graph_algorithms.cpp Outdated Show resolved Hide resolved
cpp/examples/users/multi_gpu_application/mg_graph_algorithms.cpp Outdated Show resolved Hide resolved
cpp/examples/developers/graph_operations/CMakeLists.txt Outdated Show resolved Hide resolved
ChuckHastings
ChuckHastings approved these changes Mar 14, 2024
View reviewed changes
Copy link
Collaborator

@ChuckHastings ChuckHastings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM, code wise. Agree with Don's documentation comments... will wait to merge until those are addressed.

jnke2016
jnke2016 approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@jnke2016 jnke2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the minor change requests Don had, it looks good to me

@naimnv
Copy link
Contributor Author

naimnv commented Mar 14, 2024

/okay to test

acostadon
acostadon approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@acostadon acostadon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updates look great

@naimnv
Copy link
Contributor Author

naimnv commented Mar 14, 2024

/okay to test

@naimnv
Copy link
Contributor Author

naimnv commented Mar 14, 2024

/okay to test

seunghwak
seunghwak approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@naimnv
Copy link
Contributor Author

naimnv commented Mar 15, 2024

/okay to test

@BradReesWork
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 1be5e27 into rapidsai:branch-24.04 Mar 15, 2024
142 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acostadon acostadon acostadon approved these changes

@jnke2016 jnke2016 jnke2016 approved these changes

@seunghwak seunghwak seunghwak approved these changes

@ChuckHastings ChuckHastings ChuckHastings approved these changes

Assignees

@naimnv naimnv

Labels
CMake cuGraph feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Milestone
24.04
Development

Successfully merging this pull request may close these issues.

Need basic C++ "hello world" example(s) for libcugraph
7 participants
@naimnv @seunghwak @BradReesWork @ChuckHastings @jnke2016 @acostadon @nv-rliu