Add environment-agnostic scripts for running ctests and pytests #4152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trxcllnt
added
improvement
|
Seems like the C++ tests are silently failing, but seeing #4148, I don't think it's related to the changes in this PR. |
|
The silent failure of C++ tests should be fixed by rapidsai/rapids-cmake#533 which was merged two hours ago. You'll have to restart the whole workflow (not just rerun tests). |
…eneric-test-scripts
trxcllnt
force-pushed
the
fea/generic-test-scripts
branch
from
5d5151c to
f139507
Compare
…eneric-test-scripts
AyodeAwe
approved these changes
Feb 20, 2024
…eneric-test-scripts
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds environment-agnostic
run_*_{ctests,pytests}.shscripts, and updatestest_*_{cpp,python}.shto call them.The
test_*_{cpp,python}.shscripts assume they're running in our CI environment, and they do more than just run the tests.This PR allows devs and downstream consumers to only run the tests, and skip the unrelated logic in
test_*_{cpp,python}.sh.