Removes APIs that have been deprecated and have exceeded the grace period, improves *_warning_wrapper performance #4176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ded the grace period, adds option to bypass expensive inspect.stack() lookup when forming warning messages, removes unnecessary api_tools.py wrapper in cugraph and calls pylibcugraph api_tools directly.
…ests to not use deprecated/promoted experimental APIs.
rlratzel
added
improvement
…4-remove_plc_experimental
naimnv
reviewed
Feb 22, 2024
Comment on lines
+53
to
+56
| # namespace name if it could not be found. | ||
| call_stack = inspect.stack() | ||
| calling_frame = call_stack[1].frame | ||
| obj_namespace_name = calling_frame.f_locals.get("__name__") |
jnke2016
approved these changes
Feb 22, 2024
…tation, fix errors, and clean up for clarity. Removes deprecated do_expensive_check option and cleans up docstring for jaccard functions.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
acostadon
reviewed
Feb 23, 2024
acostadon
reviewed
Feb 23, 2024
acostadon
requested changes
Feb 23, 2024
acostadon
approved these changes
Feb 23, 2024
BradReesWork
approved these changes
Feb 23, 2024
|
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Feb 28, 2024
Followup to PR #4176 to add additional detail to the Jaccard notebook. * Adds revision history to bottom * Adds more detail to Jaccard description * Adds cell output * Adds example of using the `vertex_pair` arg Authors: - Rick Ratzel (https://github.com/rlratzel) Approvers: - Don Acosta (https://github.com/acostadon) - Brad Rees (https://github.com/BradReesWork) URL: #4189
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*_warning_wrapperutilities to accept a namespace name to use in the warning messages instead of making an expensiveinspect.stack()call.inspect.stack()is still used if a namespace name was not provided. This reduces overallimporttime, especially when used withcudf.pandas(attn: @shwina).cugraph.utilities.api_toolsmodule in favor of just using the equivalentpylibcugraphmodule directly.